Repository navigation
Conversation
sonukapoor
left a comment
There was a problem hiding this comment.
The report is right and so is the diagnosis. I fetched all four URLs: both of the current ones return 404 and both of yours return 200, so this does restore the images.
What I would rather do is fix the class instead of the instance. We already keep four case-study logos in the site's own static images folder, Storybook, Mastra, VS Code and n8n, and the two that just broke are broken precisely because they were hotlinked instead. Swapping one hotlink for another leaves them one upstream site reshuffle away from breaking again, and on a page we point journalists and adopters at.
So: download those two files into the static images folder and reference them locally, the same way the Storybook one is done. Same two lines of change, and it stops being our problem. Thanks for catching this, broken images on the case studies are worse than they look given who reads those pages.
785530c to
52d909e
Compare
|
Done — both logos are now vendored into |
sonukapoor
left a comment
There was a problem hiding this comment.
This is the version I wanted, thank you. Both files are vendored now and referenced with the site base path in front, which is exactly how the other eighteen case-study logos are done.
I pulled both off your branch to be sure they are not empty placeholders: the Analog one is a real 9.7KB SVG and the Ghost one is a 400 by 400 PNG at 44KB. Both upstream URLs are still returning 404, so this does fix the pages rather than moving the breakage.
Approved.
What changed and why
The Analog and Ghost case studies render a broken logo because both upstream raw GitHub paths now return 404.
Rather than swap one hotlink for another, this vendors both logos into the site's own static images folder and references them locally, matching how the Storybook, Mastra, VS Code, and n8n logos are handled:
website/static/img/analog-logo.svgwebsite/static/img/ghost-logo.pngwebsite/docs/case-studies/analog.mdwebsite/docs/case-studies/ghost.mdCloses #1376