Skip to content

Support Helm 4 rollback-on-failure flag in KOS - #2203

Merged
APErebus merged 3 commits into
mainfrom
ap/kos-helm-4
Nov 5, 2026
Merged

APErebus merged 3 commits into
mainfrom
ap/kos-helm-4

Conversation

@APErebus

@APErebus APErebus commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Helm 4 has a replacement flag for --atomic: --rollback-on-failure.

If this flag has not set by the users in the additional args, and they have enabled KOS, then we need to enable the --wait flag

@APErebus APErebus changed the title Add rollback-on-failure check to HelmUpgradeExecutor Support Helm 4 rollback-on-failure flag as KOS fallback Nov 5, 2026
@APErebus APErebus changed the title Support Helm 4 rollback-on-failure flag as KOS fallback Support Helm 4 rollback-on-failure flag in KOS Nov 5, 2026
@APErebus
APErebus requested a review from flin-8 November 5, 2026 00:56
@APErebus
APErebus requested a review from flin-8 November 5, 2026 01:21

@flin-8 flin-8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@APErebus
APErebus enabled auto-merge (squash) November 5, 2026 01:31
@APErebus
APErebus merged commit c370f7c into main Nov 5, 2026
41 checks passed
@APErebus
APErebus deleted the ap/kos-helm-4 branch November 5, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants