Modeling Algorithms - CPU performance optimizations for Draw display and Bop#1098
Draft
dpasukhi wants to merge 1 commit intoOpen-Cascade-SAS:IRfrom
Draft
Modeling Algorithms - CPU performance optimizations for Draw display and Bop#1098dpasukhi wants to merge 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi wants to merge 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
…and Boolean operations Draw segment batching: replace fixed-size `Draw_XSegment[1000]` array with `std::vector` to eliminate forced flushes every 1000 segments. Add constructor to `Draw_XSegment` for in-place construction via `emplace_back`. Remove dead `#else` code path in `DrawTo`. Boolean IsClosedFF caching: pre-compute edge closedness per face into `NCollection_DataMap` before the 4-level nested edge loop in `BOPAlgo_PaveFiller::PerformFF`, reducing O(N1*N2) calls to O(N1+N2) pre-computation with O(1) lookups. Boolean IsInside edge bounds caching: pre-compute `TopExp::MapShapes` edge maps per solid in `BOPAlgo_BuilderSolid::PerformAreas` before the hole-matching loop, avoiding redundant topology traversal when the same solid is checked against multiple hole shells.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draw segment batching: replace fixed-size
Draw_XSegment[1000]array withstd::vectorto eliminate forced flushes every 1000 segments. Add constructor toDraw_XSegmentfor in-place construction viaemplace_back. Remove dead#elsecode path inDrawTo.Boolean IsClosedFF caching: pre-compute edge closedness per face into
NCollection_DataMapbefore the 4-level nested edge loop inBOPAlgo_PaveFiller::PerformFF, reducing O(N1*N2) calls to O(N1+N2) pre-computation with O(1) lookups.Boolean IsInside edge bounds caching: pre-compute
TopExp::MapShapesedge maps per solid inBOPAlgo_BuilderSolid::PerformAreasbefore the hole-matching loop, avoiding redundant topology traversal when the same solid is checked against multiple hole shells.