feat(windows): SendInput 模式下可选隐藏键盘列表中的 OpenLess (Fixes #738)#740
Open
HKLHaoBin wants to merge 8 commits into
Open
feat(windows): SendInput 模式下可选隐藏键盘列表中的 OpenLess (Fixes #738)#740HKLHaoBin wants to merge 8 commits into
HKLHaoBin wants to merge 8 commits into
Conversation
Add windowsSendInputInsertionOnly so users who cannot restore their IME after dictation can opt into Unicode SendInput without switching to OpenLess TSF at session start. Open-Less#733 Co-authored-by: Cursor <cursoragent@cursor.com>
Serde camelCase produced windowsSendinputInsertionOnly while the UI sends windowsSendInputInsertionOnly, causing the toggle to revert after save. Add explicit rename/alias on UserPreferences wire types and contract tests. Refs Open-Less#733 Co-authored-by: Cursor <cursoragent@cursor.com>
…mode (Fixes Open-Less#738) Add windowsShowOpenlessInKeyboardList pref with TSF EnableLanguageProfile apply on startup/save, transactional rollback with ASR sync, and UI error toast/refresh for both SendInput and keyboard-list toggles. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
PR Reviewer Guide 🔍(Review updated until commit 0cab357)Here are some key observations to aid the review process:
|
Contributor
Author
|
更改 13 个文件, 485 行插入(+), 15 行删除(-) |
• 引入 WindowsInsertionMode 枚举,用于管理文本插入策略(TSF、SendInput、粘贴)。 • 添加 WindowsSendInputNewlineMode 枚举,用于指定 SendInput 中的换行符处理方式。 • 更新 TextInserter,以支持 Windows 的新插入方法和选项。 • 重构 Unicode 按键处理,以适应换行符模拟模式。 • 增强用户偏好设置,包含新的插入模式及其各自的默认值。 • 更新 UI 组件,允许用户选择首选的插入方法和换行处理方式。 • 改进了英文、日文、韩文、简体中文和繁体中文新设置的本地化。 • 添加了测试以验证新功能,并确保文本插入符合预期行为。
…738-keyboard-list-visibility
Contributor
|
Persistent review updated to latest commit bfd440c |
…-only' into feat/issue-738-keyboard-list-visibility
Contributor
|
Persistent review updated to latest commit 0cab357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
efresh()\ 回滚 UI;修复 Hook 顺序问题。
本 PR 基于 SendInput-only 插入模式(#733 相关提交),#738 的键盘列表开关仅在 SendInput 开启时可见。
关联 Issue
Fixes #738
Test plan
pm run build\ 通过
Made with Cursor
PR Type
Enhancement
Description
Add Windows insertion mode preference (TSF, SendInput, Paste)
Add SendInput newline simulation (Enter, Shift+Enter, CR+LF)
Option to hide OpenLess from keyboard list in SendInput mode
Update settings UI and i18n for new controls
Diagram Walkthrough
File Walkthrough
3 files
Add test harness for Windows modulesUpdate mock data with new prefsUpdate test data with new prefs10 files
Refactor persist_settings with keyboard apply and rollbackAdd SendInput options and insertion mode to dictation error codeUse insertion mode to skip TSF prepare and control streamingUpdate insert_via_unicode_keystrokes to accept optionsApply keyboard list visibility on startupAdd WindowsInsertionMode, WindowsSendInputNewlineMode, and new prefsAdd newline simulation and typed char countingImplement keyboard list visibility toggle via TSF profileAdd TypeScript types for Windows insertion modeAdd UI for insertion mode, newline mode, and keyboard list toggle5 files
Add English i18n keys for new settingsAdd Japanese i18n keys for new settingsAdd Korean i18n keys for new settingsAdd Simplified Chinese i18n keys for new settingsAdd Traditional Chinese i18n keys for new settings