[feat][elixir] use elixir 1.18 built-in json module#21039
[feat][elixir] use elixir 1.18 built-in json module#21039mrmstn merged 2 commits intoOpenAPITools:masterfrom
Conversation
|
Hi @efcasado, Nice! Thanks for submitting this PR—it looks good to me. I just want to run a quick test tomorrow to ensure it's as straightforward as it looks like 😄 . @wing328 — Regarding versioning, this change doesn't technically break the client's API but does introduce a dependency on Elixir 1.18. Given that earlier versions are already EOL, my feeling is that it's safe to merge into master. However, I'm open to your thoughts—what's your take? |
sounds good to me too users who need to use older versions of Elixir with the generated client can pin openapi generator to v7.12.0 without upgrading to newer versions that no longer support outdated Elixir versions |
|
Just a quick update - looks like my nix environment still does not know elixir 1.18 - I'm currently figuring out on how to force the update since it's already available in 24.11 😅 |
Description
A potential implementation for #21038.
Curious to hear your thoughts, @mrmstn.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)