Skip to content

Fix the layout issue in the donation message#21184

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ackintosh:fix-donation-message
Apr 29, 2025
Merged

Fix the layout issue in the donation message#21184
wing328 merged 1 commit intoOpenAPITools:masterfrom
ackintosh:fix-donation-message

Conversation

@ackintosh
Copy link
Copy Markdown
Contributor

@ackintosh ackintosh commented Apr 29, 2025

Issue Addressed

The emoji might not render correctly for some users. I saw that a user complained about the following layout issue in the donation message on social media. I believe he is a Windows user.

image

This PR removes the emoji from the message and replaces it with some text. The message looks like:

image

I know that some of ***Codegen classes implement their own donation message, but I have fixed DefaultCodegen only because of my limited bandwidth. 🙇

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

The emoji might not render correctly for Windows users.
@wing328 wing328 merged commit 3bac186 into OpenAPITools:master Apr 29, 2025
14 checks passed
@ackintosh ackintosh deleted the fix-donation-message branch April 29, 2025 20:42
@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 30, 2025

I know that some of ***Codegen classes implement their own donation message, but I have fixed DefaultCodegen only because of my limited bandwidth. 🙇

We'll take care of the rest based on your fix 👍

@wing328 wing328 added this to the 7.14.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants