Skip to content

Provide " as member" where needed #21304

Merged
wing328 merged 6 commits intomasterfrom
robertleeplummerjr-master
May 20, 2025
Merged

Provide " as member" where needed #21304
wing328 merged 6 commits intomasterfrom
robertleeplummerjr-master

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented May 20, 2025

to fix #20878

based on #20887

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

robert-lore and others added 6 commits March 14, 2025 08:51
- Generate new samples
- Add tests for all effected python versions
- Ran tests with success

Commands used to verify:
./bin/generate-samples.sh ./bin/configs/python*
mvn verify -Psamples
mvn integration-test -f modules/openapi-generator/pom.xml -Dtest=org.openapitools.codegen.python.PythonPydanticV1ClientCodegenTest -e
mvn integration-test -f modules/openapi-generator/pom.xml -Dtest=org.openapitools.codegen.python.PythonClientCodegenTest -e
@wing328 wing328 changed the title Robertleeplummerjr master Provide " as member" where needed May 20, 2025
@wing328 wing328 marked this pull request as ready for review May 20, 2025 08:24
@wing328 wing328 added this to the 7.14.0 milestone May 20, 2025
@wing328 wing328 merged commit 5f63385 into master May 20, 2025
56 of 60 checks passed
@wing328 wing328 deleted the robertleeplummerjr-master branch May 20, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][python] Clients throws reportPrivateImportUsage when used as a package

2 participants