Skip to content

Fix typo in CLI command#21534

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
dani-garcia:fix-typo
Jul 9, 2025
Merged

Fix typo in CLI command#21534
wing328 merged 1 commit intoOpenAPITools:masterfrom
dani-garcia:fix-typo

Conversation

@dani-garcia
Copy link
Copy Markdown
Contributor

Just a small typo I noticed while looking through the CLI config options.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@dani-garcia
Copy link
Copy Markdown
Contributor Author

CI is complaining about an out of date sample, but this seems unrelated to this change:

diff --git forkSrcPrefix/samples/openapi3/server/petstore/spring-boot-oneof-sealed/src/main/java/org/openapitools/model/Fruit.java forkDstPrefix/samples/openapi3/server/petstore/spring-boot-oneof-sealed/src/main/java/org/openapitools/model/Fruit.java
index 5062b4c48eb10e5dc7cc46f0f120efafb01b3741..86be74c431b0ae51295a19a4d91b2838a15d03de 100644
--- forkSrcPrefix/samples/openapi3/server/petstore/spring-boot-oneof-sealed/src/main/java/org/openapitools/model/Fruit.java
+++ forkDstPrefix/samples/openapi3/server/petstore/spring-boot-oneof-sealed/src/main/java/org/openapitools/model/Fruit.java
@@ -30,9 +30,7 @@ import javax.annotation.Generated;
 @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY, property = "fruitType", visible = true)
 @JsonSubTypes({
   @JsonSubTypes.Type(value = Apple.class, name = "APPLE"),
-  @JsonSubTypes.Type(value = Banana.class, name = "BANANA"),
-  @JsonSubTypes.Type(value = Apple.class, name = "Apple"),
-  @JsonSubTypes.Type(value = Banana.class, name = "Banana")
+  @JsonSubTypes.Type(value = Banana.class, name = "BANANA")
 })
 
 @Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.15.0-SNAPSHOT")

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jul 9, 2025

agreed it's not related to this pr

will; fix it shortly

@wing328 wing328 merged commit 9918836 into OpenAPITools:master Jul 9, 2025
13 of 14 checks passed
@dani-garcia dani-garcia deleted the fix-typo branch July 10, 2025 18:27
@wing328 wing328 added this to the 7.15.0 milestone Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants