Skip to content

Define codegen vendor extensions in CodegenConstants#22054

Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom
Mattias-Sehlstedt:codegen-vendor-extension
Oct 1, 2025
Merged

Define codegen vendor extensions in CodegenConstants#22054
wing328 merged 5 commits intoOpenAPITools:masterfrom
Mattias-Sehlstedt:codegen-vendor-extension

Conversation

@Mattias-Sehlstedt
Copy link
Copy Markdown
Contributor

Similarly to how vendor extensions for clients are defined in a shared place, I believe it would be beneficial if the internal ones were also centralized in a similar way. This is both helpful for viewing where an extension is used and how, and it also increases the likelihood that a Codegen implementation for one language can see how a similar idea is realized for another language (and with that, that it might be a behavior that should be implemented in a common Codegen).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 merged commit e8a688a into OpenAPITools:master Oct 1, 2025
14 checks passed
@wing328 wing328 added this to the 7.17.0 milestone Nov 6, 2025
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
)

* Add an enum to centralize common internal vendor extensions used for Codegen processing

* Extend the normalizer tests to illustrate that an AllOfs with several refs have all of them marked as parents

* Add x-internal to the Codegen vendor extensions

* Move the Codegen vendor extensions into CodegenConstants

* Add assertion to JavaClient CodegenTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants