Skip to content

[PYTHON][bugfix]Fix python model dict array generation #23538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into from
Apr 27, 2026
Merged

[PYTHON][bugfix]Fix python model dict array generation #23538

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2151943
Fix python model dict array generation
ilayu-blip Apr 14, 2026
46e1bda
Merge branch 'master' into python-sdk-models-array-bug
wing328 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,3 +309,6 @@ samples/client/petstore/ocaml-recursion-test/_build/

# jetbrain http client
samples/client/jetbrains/adyen/checkout71/http/client/Apis/http-client.private.env.json

# Generated by the run-in-docker.sh
\?/
14 changes: 6 additions & 8 deletions modules/openapi-generator/src/main/resources/python-fastapi/model_generic.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,14 +317,12 @@ class {{classname}}({{#parent}}{{{.}}}{{/parent}}{{^parent}}BaseModel{{/parent}}
else None{{^-last}},{{/-last}}
{{/items.isMap}}
{{#items.isArray}}
"{{{baseName}}}": dict(
(_k,
[{{{items.items.dataType}}}.from_dict(_item) for _item in _v]
if _v is not None
else None
)
for _k, _v in obj.get("{{{baseName}}}").items()
){{^-last}},{{/-last}}
"{{{baseName}}}": {
_k: [{{{items.items.dataType}}}.from_dict(_item) for _item in _v] if _v is not None else None
for _k, _v in obj["{{{baseName}}}"].items()
}
if obj.get("{{{baseName}}}") is not None
else None{{^-last}},{{/-last}}
{{/items.isArray}}
{{/items.isContainer}}
{{^items.isContainer}}
Expand Down
14 changes: 6 additions & 8 deletions modules/openapi-generator/src/main/resources/python/model_generic.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,14 +380,12 @@ class {{classname}}({{#parent}}{{{.}}}{{/parent}}{{^parent}}BaseModel{{/parent}}
else None{{^-last}},{{/-last}}
{{/items.isMap}}
{{#items.isArray}}
"{{{baseName}}}": dict(
(_k,
[{{{items.items.dataType}}}.from_dict(_item) for _item in _v]
if _v is not None
else None
)
for _k, _v in obj.get("{{{baseName}}}", {}).items()
){{^-last}},{{/-last}}
"{{{baseName}}}": {
_k: [{{{items.items.dataType}}}.from_dict(_item) for _item in _v] if _v is not None else None
for _k, _v in obj["{{{baseName}}}"].items()
}
if obj.get("{{{baseName}}}") is not None
else None{{^-last}},{{/-last}}
{{/items.isArray}}
{{/items.isContainer}}
{{^items.isContainer}}
Expand Down
14 changes: 6 additions & 8 deletions samples/openapi3/client/petstore/python-aiohttp/petstore_api/models/map_of_array_of_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,12 @@ def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
return cls.model_validate(obj)

_obj = cls.model_validate({
"shopIdToOrgOnlineLipMap": dict(
(_k,
[Tag.from_dict(_item) for _item in _v]
if _v is not None
else None
)
for _k, _v in obj.get("shopIdToOrgOnlineLipMap", {}).items()
)
"shopIdToOrgOnlineLipMap": {
_k: [Tag.from_dict(_item) for _item in _v] if _v is not None else None
for _k, _v in obj["shopIdToOrgOnlineLipMap"].items()
}
if obj.get("shopIdToOrgOnlineLipMap") is not None
else None
})
return _obj

Expand Down
14 changes: 6 additions & 8 deletions .../python-aiohttp/petstore_api/models/unnamed_dict_with_additional_model_list_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,12 @@ def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
return cls.model_validate(obj)

_obj = cls.model_validate({
"dictProperty": dict(
(_k,
[CreatureInfo.from_dict(_item) for _item in _v]
if _v is not None
else None
)
for _k, _v in obj.get("dictProperty", {}).items()
)
"dictProperty": {
_k: [CreatureInfo.from_dict(_item) for _item in _v] if _v is not None else None
for _k, _v in obj["dictProperty"].items()
}
if obj.get("dictProperty") is not None
else None
})
return _obj

Expand Down
14 changes: 6 additions & 8 deletions samples/openapi3/client/petstore/python-httpx/petstore_api/models/map_of_array_of_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,12 @@ def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
return cls.model_validate(obj)

_obj = cls.model_validate({
"shopIdToOrgOnlineLipMap": dict(
(_k,
[Tag.from_dict(_item) for _item in _v]
if _v is not None
else None
)
for _k, _v in obj.get("shopIdToOrgOnlineLipMap", {}).items()
)
"shopIdToOrgOnlineLipMap": {
_k: [Tag.from_dict(_item) for _item in _v] if _v is not None else None
for _k, _v in obj["shopIdToOrgOnlineLipMap"].items()
}
if obj.get("shopIdToOrgOnlineLipMap") is not None
else None
})
return _obj

Expand Down
14 changes: 6 additions & 8 deletions ...re/python-httpx/petstore_api/models/unnamed_dict_with_additional_model_list_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,12 @@ def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
return cls.model_validate(obj)

_obj = cls.model_validate({
"dictProperty": dict(
(_k,
[CreatureInfo.from_dict(_item) for _item in _v]
if _v is not None
else None
)
for _k, _v in obj.get("dictProperty", {}).items()
)
"dictProperty": {
_k: [CreatureInfo.from_dict(_item) for _item in _v] if _v is not None else None
for _k, _v in obj["dictProperty"].items()
}
if obj.get("dictProperty") is not None
else None
})
return _obj

Expand Down
14 changes: 6 additions & 8 deletions .../openapi3/client/petstore/python-lazyImports/petstore_api/models/map_of_array_of_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,12 @@ def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
return cls.model_validate(obj)

_obj = cls.model_validate({
"shopIdToOrgOnlineLipMap": dict(
(_k,
[Tag.from_dict(_item) for _item in _v]
if _v is not None
else None
)
for _k, _v in obj.get("shopIdToOrgOnlineLipMap", {}).items()
)
"shopIdToOrgOnlineLipMap": {
_k: [Tag.from_dict(_item) for _item in _v] if _v is not None else None
for _k, _v in obj["shopIdToOrgOnlineLipMap"].items()
}
if obj.get("shopIdToOrgOnlineLipMap") is not None
else None
})
# store additional fields in additional_properties
for _key in obj.keys():
Expand Down
14 changes: 6 additions & 8 deletions ...hon-lazyImports/petstore_api/models/unnamed_dict_with_additional_model_list_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,12 @@ def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
return cls.model_validate(obj)

_obj = cls.model_validate({
"dictProperty": dict(
(_k,
[CreatureInfo.from_dict(_item) for _item in _v]
if _v is not None
else None
)
for _k, _v in obj.get("dictProperty", {}).items()
)
"dictProperty": {
_k: [CreatureInfo.from_dict(_item) for _item in _v] if _v is not None else None
for _k, _v in obj["dictProperty"].items()
}
if obj.get("dictProperty") is not None
else None
})
# store additional fields in additional_properties
for _key in obj.keys():
Expand Down
14 changes: 6 additions & 8 deletions samples/openapi3/client/petstore/python/petstore_api/models/map_of_array_of_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,12 @@ def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
return cls.model_validate(obj)

_obj = cls.model_validate({
"shopIdToOrgOnlineLipMap": dict(
(_k,
[Tag.from_dict(_item) for _item in _v]
if _v is not None
else None
)
for _k, _v in obj.get("shopIdToOrgOnlineLipMap", {}).items()
)
"shopIdToOrgOnlineLipMap": {
_k: [Tag.from_dict(_item) for _item in _v] if _v is not None else None
for _k, _v in obj["shopIdToOrgOnlineLipMap"].items()
}
if obj.get("shopIdToOrgOnlineLipMap") is not None
else None
})
# store additional fields in additional_properties
for _key in obj.keys():
Expand Down
14 changes: 6 additions & 8 deletions ...petstore/python/petstore_api/models/unnamed_dict_with_additional_model_list_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,12 @@ def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
return cls.model_validate(obj)

_obj = cls.model_validate({
"dictProperty": dict(
(_k,
[CreatureInfo.from_dict(_item) for _item in _v]
if _v is not None
else None
)
for _k, _v in obj.get("dictProperty", {}).items()
)
"dictProperty": {
_k: [CreatureInfo.from_dict(_item) for _item in _v] if _v is not None else None
for _k, _v in obj["dictProperty"].items()
}
if obj.get("dictProperty") is not None
else None
})
# store additional fields in additional_properties
for _key in obj.keys():
Expand Down
Loading