Skip to content

[BUG] Fix Patch operations reset fields to default if not specified #23650 #23676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swapneswarsundarray wants to merge 3 commits into from
+20 −0
Closed

[BUG] Fix Patch operations reset fields to default if not specified #23650 #23676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d27cc40
Fix Python PATCH serialization for unset default fields
swapneswarsundarray May 2, 2026
a3ec44e
fix(python): Use exclude_unset=True for PATCH models
swapneswarsundarray May 2, 2026
2d3bd2e
fixes #23650(python): Clean up Mustache template condition to prevent…
swapneswarsundarray May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...enapi-generator/src/main/java/org/openapitools/codegen/languages/PythonClientCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
import org.openapitools.codegen.meta.GeneratorMetadata;
import org.openapitools.codegen.meta.Stability;
import org.openapitools.codegen.meta.features.*;
import org.openapitools.codegen.model.ModelMap;
import org.openapitools.codegen.model.ModelsMap;
import org.openapitools.codegen.utils.ModelUtils;
import org.openapitools.codegen.utils.ProcessUtils;
import org.slf4j.Logger;
Expand Down Expand Up @@ -434,6 +436,19 @@ public String modelTestFileFolder() {
return outputFolder + File.separatorChar + testFolder;
}

@Override
public ModelsMap postProcessModels(ModelsMap objs) {
// Process models to detect PATCH models (models starting with 'Patched')
for (ModelMap mo : objs.getModels()) {
CodegenModel cm = mo.getModel();
if (cm.getClassname().startsWith("Patched")) {
// Mark as PATCH model for template handling
cm.vendorExtensions.put("isPatchedModel", true);
}
}
return super.postProcessModels(objs);
}

public String packagePath() {
return packageName.replace('.', File.separatorChar);
}
Expand Down
5 changes: 5 additions & 0 deletions modules/openapi-generator/src/main/resources/python/model_generic.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,12 @@ class {{classname}}({{#parent}}{{{.}}}{{/parent}}{{^parent}}BaseModel{{/parent}}
_dict = self.model_dump(
by_alias=True,
exclude=excluded_fields,
{{#vendorExtensions.isPatchedModel}}
exclude_unset=True, # For PATCH models, exclude unset fields to avoid sending default values
{{/vendorExtensions.isPatchedModel}}
{{^vendorExtensions.isPatchedModel}}
exclude_none=True,
{{/vendorExtensions.isPatchedModel}}
)
{{#allVars}}
{{#isContainer}}
Expand Down