Repository navigation
Conversation
Fix stale paths in claude.md and copilot instructions, add a self-review step and design rules for generated adaptors, document pagination and state conventions in best-practice, and fold recurring maintainer review feedback into wiki/code-review.md. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 23, 2026
Member
|
@mtuchi , was this better or worse for Jack's open street map adaptor? I think that's the most interesting data point we have when deciding if we should merge this pr. |
Scope the apiVersion rule to versioned APIs with a default set in code, note the override trade-off, clarify how common's request surfaces upstream errors, and require tests per index.js export. Add rules for client-side validation and multi-page pagination tests. Bring copilot-instructions in line with claude.md and import from index.js in the generator test template. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From review of the openstreetmap adaptor (#1833): name functions with a verb for what they do rather than after the endpoint they call, and put the unit in option names that have one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01De8BkeiGnA7aM4fARhetDC
Rewrite the pagination rules to cover any operation that returns a collection and any paging style (offset, page number, cursor, next link), and align claude.md and code-review.md with them. Restore the Utils.js and Adaptor.js request signatures in copilot-instructions, matching the generator template. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Hey @PiusKariuki or @hunterachieng can you take a look at this pr when you have capacity ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the adaptor generation and code review guidance, based on problems found reviewing the AI-generated copper and lemlist adaptors (#1828).
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.
pnpm run versionused to bump versions (notpnpm changeset versiondirectly)? This ensures changelog dates are stamped correctly.