Repository navigation
Track workflow renames - #1596
Draft
josephjclark wants to merge 6 commits into
Draft
josephjclark wants to merge 6 commits into
josephjclark wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Difficult branch to resolve issue #1594 and replace PR #1587
The basic problem we have is this:
Locally, the CLI uses an
id, derived on checkout from a workflow'sname, to identify workglows. This id is used as a key in various bits of tracking.When a workflow name changes in the app, or if a user renames a workflow on the file system, the id changes and a lot of the tracking against that workflow breaks.
Now this can be resolved simply with a fresh checkout, which is what #1587 does. But a deploy shouldn't do a full checkout, and it encourages workflow folders to be deleted, rather than renamed.
What I want is better tracking of workflow identity so that a rename isn't totally distructive.
Here's how we're achieving that.
What this PR basically does is track the UUIDs of each workflow in the checkout.yaml file, and uses UUIDs to match local to remote workflows. When a workflow name changes locally, the id and local paths arent updated - they basically are used as aliases. Users can fix the local paths if they want, or maybe we'll add CLI utils for this. But for now, paths stay the same.
Here's a bit more detail on the changes:
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy