Repository navigation
spark_dataproc: resolve each jar URL in get_openlineage_jar.sh independently - #343
Merged
Merged
Conversation
tnazarew
force-pushed
the
spark/jar-url-defaults
branch
from
October 21, 2026 17:08
83876fa to
7bc6223
Compare
tnazarew
marked this pull request as ready for review
October 21, 2026 17:29
…ndently Previously the BigQuery connector, Spanner and Bigtable URLs from the cluster metadata were used only when OPENLINEAGE_SPARK_URL was set; otherwise all four fell back to the defaults. Now each URL is taken from its own metadata attribute and falls back to its own default, so e.g. a cluster created with only OPENLINEAGE_SPARK_URL still gets the default connectors and a custom connector URL is not ignored. CI passes all four URLs, so its jars are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com>
tnazarew
force-pushed
the
spark/jar-url-defaults
branch
from
October 21, 2026 17:29
7bc6223 to
f60af65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_openlineage_jar.sh(the Dataproc init action that installs the jars) read the BigQuery connector, Spanner and Bigtable URLs from cluster metadata only whenOPENLINEAGE_SPARK_URLwas set. Otherwise all four fell back to hardcoded defaults. This means:OPENLINEAGE_SPARK_URLgot empty connector URLs andgsutil cp ""failed;Change
Each URL is now read from its own metadata attribute and falls back to its own default (
metadata_or_default). The default values are unchanged.Impact
producer_spark_dataproc.yml) passes all four URLs, so the installed jars do not change.gs://open-lineage-e2e/scripts/on every run, so other runs pick it up once this is merged.Testing
bash -n, plus a run with stubbedget_metadata_valueandgsutil:OPENLINEAGE_SPARK_URLNot yet run on a real Dataproc cluster beyond this PR's CI.
🤖 Generated with Claude Code