Repository navigation
fix(konflux): fix failing ec's in main - #592
Merged
Merged
Conversation
Contributor
Author
|
Fix also seen elsewhere (like in openshift-online/hypershell#801) |
Contributor
Author
|
Going to merge and keep an eye on the main EC's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
whenguard to all six legacy Konflux PipelineRuns soprefetch-dependenciesis skipped whenprefetch-inputis empty.Background
The legacy prefetch task emits no results when there is no input. Tekton Chains then omits
status.resultsfrom the SLSA v1 attestation, causing Conforma to miss the task parameters and report:prefetch_dependencies.package_registry_proxy_enabledContext: https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1793075906701849
Tracking: https://redhat.atlassian.net/browse/KFLUXSPRT-9412
Changes
prefetch-dependencieswhenprefetch-inputis empty.enable-package-registry-proxyparameter default oftrue.Validation
git diff --checkpasses.This is a workaround for the legacy pipeline behavior. Migration to OCI-TA or the upstream Conforma fix remains the long-term solution.