Skip to content

Switch binary release to use Compute#921

Open
Kyle-Ye wants to merge 4 commits into
mainfrom
optimize/compute_release
Open

Switch binary release to use Compute#921
Kyle-Ye wants to merge 4 commits into
mainfrom
optimize/compute_release

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Jun 23, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added area: tooling Developer tooling, package manifests, Tuist, scripts, formatting, or release tooling. type: build Build system, packaging, toolchain, release, or compiler support. type: ci GitHub Actions, test infrastructure, runners, checks, or automation. labels Jun 23, 2026
@augmentcode

augmentcode Bot commented Jun 23, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR updates the binary release pipeline to build OpenSwiftUI’s distribution XCFrameworks using the Compute backend.

Changes:

  • Switches the composite XCFramework build action to call Scripts/build_xcframework.sh --compute.
  • Updates the release workflow env defaults to select the Compute OpenAttributeGraphShims backend.
  • Adds Scripts/CI/compute_setup.sh and wires it into the Darwin CI dependency setup sequence.
  • Extends Scripts/build_xcframework.sh with --compute/--help, and includes iphoneos slices by default for Compute builds.
  • Makes checksum generation more robust by removing any pre-existing zip before recomputing checksums.
  • Refactors the OpenSwiftUI-spm update step to render Package.swift via a helper, update README version, and commit only when changes exist.
  • Adds Tuist target settings in Package.swift to embed backend/library/build metadata into the OpenSwiftUI framework Info.plist.

Technical Notes: Compute is cloned/checked out alongside other sibling repos during CI setup, and release checksums are computed from the freshly rebuilt zipped XCFrameworks.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

SDKS=("macosx" "iphonesimulator")
SDK_ARCHS=("" "")
if [ "${OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE:-0}" = "1" ]; then
SDKS=("macosx" "iphonesimulator" "iphoneos")

@augmentcode augmentcode Bot Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that --compute adds iphoneos to the default SDK list, the xcodebuild archive step may start requiring device code-signing/provisioning on CI; consider explicitly disabling code signing for the archive builds if project settings don’t already do this. This helps avoid release failures where signing identities are only configured later in the workflow.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.77%. Comparing base (34f1c0c) to head (092382c).
⚠️ Report is 7 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (34f1c0c) and HEAD (092382c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (34f1c0c) HEAD (092382c)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #921       +/-   ##
===========================================
- Coverage   26.04%   13.77%   -12.27%     
===========================================
  Files         717      677       -40     
  Lines       50566    44486     -6080     
===========================================
- Hits        13168     6130     -7038     
- Misses      37398    38356      +958     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: tooling Developer tooling, package manifests, Tuist, scripts, formatting, or release tooling. type: build Build system, packaging, toolchain, release, or compiler support. type: ci GitHub Actions, test infrastructure, runners, checks, or automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant