Repository navigation
refactor: take the config API from the web library - #275
Merged
Merged
Conversation
The config store and the logic of the /api/v1/config routes now come from web-rs v0.2.0 (OpusProjects/web) instead of a copy in each service: which files make up the directory, staging and atomic commits (FsConfigStore, built with this service's loader by fs_store), ConfigErrors, and every route's logic (If-Match, ETags, validate, commit, reload). What stays here: the route functions with their OpenAPI annotations, ConfigSummary and ReloadInfo, and a ConfigHost saying what a reload does and which API keys it leaves in force. The responses are unchanged; in the OpenAPI document WriteResult and ValidationResult appear under their instantiated names (WriteResult_ConfigSummary_ReloadInfo, ValidationResult_ConfigSummary). The end-to-end config API tests pass unchanged; the store's unit tests moved to web-rs with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config store and the logic of the /api/v1/config routes now come from web-rs v0.2.0 (OpusProjects/web) instead of a copy in each service: which files make up the directory, staging and atomic commits (FsConfigStore, built with this service's loader by fs_store), ConfigErrors, and every route's logic (If-Match, ETags, validate, commit, reload).
What stays here: the route functions with their OpenAPI annotations, ConfigSummary and ReloadInfo, and a ConfigHost saying what a reload does and which API keys it leaves in force. The responses are unchanged; in the OpenAPI document WriteResult and ValidationResult appear under their instantiated names (WriteResult_ConfigSummary_ReloadInfo, ValidationResult_ConfigSummary). The end-to-end config API tests pass unchanged; the store's unit tests moved to web-rs with it.