Skip to content

[CI] Explicitly require mooncake-transfer-engine>=0.3.7,<0.4.0#7891

Merged
EmmonsCurse merged 3 commits into
PaddlePaddle:developfrom
EmmonsCurse:add_mooncake-transfer-engine
May 22, 2026
Merged

[CI] Explicitly require mooncake-transfer-engine>=0.3.7,<0.4.0#7891
EmmonsCurse merged 3 commits into
PaddlePaddle:developfrom
EmmonsCurse:add_mooncake-transfer-engine

Conversation

@EmmonsCurse
Copy link
Copy Markdown
Collaborator

@EmmonsCurse EmmonsCurse commented May 22, 2026

Motivation

mooncake-transfer-engine was previously installed through transitive dependencies from p2pstore, which itself is an indirect dependency of fast_dataindex.

Dependency chain:

requirements.txt
  └─ fast_dataindex
       └─ p2pstore
            └─ (0.1.15)       mooncake-transfer-engine>=0.3.7,<0.4.0
            └─ (0.1.15.post1) dependency removed

After upgrading to p2pstore==0.1.15.post1, the implicit dependency on mooncake-transfer-engine was removed, causing mooncake_master related components to no longer be installed automatically.

Recent upstream dependency changes may cause mooncake-transfer-engine installation behavior to become unstable or inconsistent.

In addition, starting from mooncake-transfer-engine 0.3.9, released x86_64 wheels are built with:

manylinux_2_35_x86_64

while current FastDeploy CI environments still include:

  • manylinux_2_28_x86_64
  • manylinux_2_17_x86_64

According to pip compatibility rules, wheels requiring newer glibc versions cannot be installed in older environments.

This may cause installation failures in CI environments using older glibc baselines.

The purpose of this change is mainly to avoid compatibility risks introduced by newer manylinux_2_35_x86_64 wheels and preserve stable dependency installation behavior across existing CI environments.

Modifications

  • Explicitly added:
    • mooncake-transfer-engine<0.4.0,>=0.3.7
      to unittest_requirement.txt
  • Avoided relying on transitive dependency propagation from p2pstore.
  • Preserved compatibility with existing CI environments based on:
    • manylinux_2_28_x86_64
    • manylinux_2_17_x86_64
  • Reduced installation risks caused by newer incompatible wheel packaging formats.

Usage or Command

N/A

Accuracy Tests

N/A

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented May 22, 2026

Thanks for your contribution!

PaddlePaddle-bot

This comment was marked as outdated.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@3ec5011). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #7891   +/-   ##
==========================================
  Coverage           ?   72.73%           
==========================================
  Files              ?      399           
  Lines              ?    56309           
  Branches           ?     8806           
==========================================
  Hits               ?    40956           
  Misses             ?    12579           
  Partials           ?     2774           
Flag Coverage Δ
GPU 72.73% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PaddlePaddle-bot

This comment was marked as outdated.

@EmmonsCurse EmmonsCurse changed the title [CI][BugFix] Explicitly require mooncake-transfer-engine>=0.3.10 [CI][BugFix] Explicitly require mooncake-transfer-engine>=0.3.7,<0.4.0 May 22, 2026
PaddlePaddle-bot

This comment was marked as outdated.

@EmmonsCurse EmmonsCurse changed the title [CI][BugFix] Explicitly require mooncake-transfer-engine>=0.3.7,<0.4.0 [CI] Explicitly require mooncake-transfer-engine>=0.3.7,<0.4.0 May 22, 2026
@EmmonsCurse
Copy link
Copy Markdown
Collaborator Author

/skip-ci ci_iluvatar
/skip-ci ci_hpu
/skip-ci build_xpu
/skip-ci gpu_4cards_test
/skip-ci pre_ce_test
/skip-ci stable_test
/skip-ci base_test
/skip-ci logprob_test

Copy link
Copy Markdown

@PaddlePaddle-bot PaddlePaddle-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Paddle-CI-Agent | pr_review | 2026-05-22 18:25:50

📋 Review 摘要

PR 概述:将 mooncake-transfer-engine 从传递依赖改为显式依赖,锁定版本区间以避免 CI 环境因 glibc 兼容性导致的安装失败
变更范围scripts/unittest_requirement.txt
影响面 Tag[CI]

问题

级别 文件 概述
❓ 疑问 scripts/unittest_requirement.txt:13 版本上界 <0.4.0 仍包含 0.3.9+,而 PR 描述称 0.3.9 起使用 manylinux_2_35 不兼容 wheel
📝 PR 规范 Checklist 中 [ ] Add unit tests 未勾选,且 PR body 未说明不添加单测的原因

📝 PR 规范检查

标题格式符合规范([CI] 为官方 Tag),描述各必填段落(Motivation / Modifications / Usage or Command / Accuracy Tests / Checklist)均完整。

唯一小问题:Checklist 中 [ ] Add unit tests 未勾选,而模板要求 "Please write the reason in this PR if no unit tests",PR body 中未显式说明原因(对依赖文件变更而言原因自明,但建议补充以符合规范)。

建议在 Checklist 对应项补充说明(可直接复制):

- [ ] Add unit tests. Please write the reason in this PR if no unit tests.
  - This PR only modifies a requirements file with no logic code change; no unit tests are needed.

总体评价

变更动机清晰、实现简洁,将隐式传递依赖显式化是合理的 CI 稳定性修复。建议作者确认 <0.4.0 上界是否满足规避不兼容 wheel 的目标(见行间评论),其余无阻塞性问题。

pandas
use_triton_in_paddle
arctic_inference @ https://paddle-qa.bj.bcebos.com/ernie/arctic_inference-0.1.3-cp310-cp310-linux_x86_64.whl
mooncake-transfer-engine>=0.3.7,<0.4.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ 疑问 PR 描述指出 mooncake-transfer-engine 0.3.9 起 x86_64 wheel 构建使用 manylinux_2_35_x86_64,与 CI 环境(manylinux_2_28 / manylinux_2_17)不兼容。

但当前约束 >=0.3.7,<0.4.0 仍允许安装 0.3.9+。pip 的 wheel 兼容性检查会自动跳过不兼容 wheel(行为正确),但如果 0.3.9+ 的所有 wheel 都是 manylinux_2_35,pip 会回退至可用的最高兼容版本(如 0.3.8)。

请确认

  1. 0.3.9+ 是否同时发布了 manylinux_2_28 / manylinux_2_17 兼容 wheel?
  2. 如果没有,是否应将上界收紧为 <0.3.9 以显式排除不兼容版本,使意图更明确?

若当前 <0.4.0 与原 p2pstore==0.1.15 的约束保持一致且经过验证可用,可在 PR 描述中补充说明。

@EmmonsCurse EmmonsCurse merged commit 91ca3d1 into PaddlePaddle:develop May 22, 2026
43 checks passed
@EmmonsCurse EmmonsCurse deleted the add_mooncake-transfer-engine branch May 22, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants