fix: Enforce GPG signature checks on RPM repo#606
Open
dz0ny wants to merge 1 commit into
Open
Conversation
The published paretosecurity.repo set gpgcheck=0, so dnf never verified the RPM's GPG signature even though the installer imports the Pareto key first and every RPM is properly signed at release time. A compromised or mispublished repo/CDN/artifact path could have served an unsigned or maliciously signed package with no policy check blocking the install. Set gpgcheck=1 and add a release step that fails if the published repo file ever reverts to gpgcheck=0. Refs teamniteo/pareto#864
🚀 Dev Builds AvailableDevelopment builds for this PR are available in the workflow artifacts. Available builds:
Download the |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the RPM installation path by ensuring DNF enforces GPG signature verification for packages delivered via the published paretosecurity.repo, and adds a release guardrail to prevent regressions.
Changes:
- Set
gpgcheck=1in the published RPM repo configuration so DNF verifies RPM signatures. - Add a CI/release step that fails if the published
.repofile does not containgpgcheck=1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apt/rpm/paretosecurity.repo | Enables RPM signature enforcement via gpgcheck=1. |
| .github/workflows/release.yml | Adds a release-time check to prevent gpgcheck from reverting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published paretosecurity.repo set gpgcheck=0, so dnf never
verified the RPM's GPG signature even though the installer imports
the Pareto key first and every RPM is properly signed at release
time. A compromised or mispublished repo/CDN/artifact path could
have served an unsigned or maliciously signed package with no
policy check blocking the install.
Set gpgcheck=1 and add a release step that fails if the published
repo file ever reverts to gpgcheck=0.
Refs https://github.com/teamniteo/pareto/issues/864