Skip to content

fix: maxresdefault - #253

Closed
GDjkhp wants to merge 1 commit into
PerformanC:devfrom
GDjkhp:maxresdefault-fix
Closed

GDjkhp wants to merge 1 commit into
PerformanC:devfrom
GDjkhp:maxresdefault-fix

Conversation

@GDjkhp

@GDjkhp GDjkhp commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@GDjkhp

GDjkhp commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

some videos doesnt provide maxresdefault.jpeg and returns 404. let me know if should i write a parser for the following:

https://img.youtube.com/vi/<insert-youtube-video-id-here>/hqdefault.jpg
https://img.youtube.com/vi/<insert-youtube-video-id-here>/mqdefault.jpg
https://img.youtube.com/vi/<insert-youtube-video-id-here>/sddefault.jpg
https://img.youtube.com/vi/<insert-youtube-video-id-here>/maxresdefault.jpg

@GDjkhp

GDjkhp commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

ok nvm if i do that, it will cost one request per song and if i have 1000+ song playlist, its terrible 💀 keep it maxresdefault

@1Lucas1apk

Copy link
Copy Markdown
Member

I think we should keep mqdefault.jpg as the default on the NodeLink side. maxresdefault.jpg isn't available for every video, and this can be demonstrated with an actual example:

The issue is that this change only switches the default URL; it doesn't check whether the higher-resolution thumbnail actually exists. That means videos can end up with a missing thumbnail even when a lower-resolution one is available.

I think this would be better handled on the client side, such as in the bot, if higher-resolution thumbnails are needed there. That way, NodeLink can keep its current default behavior instead of changing the thumbnail URL for every consumer.

@1Lucas1apk 1Lucas1apk closed this Oct 20, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants