Skip to content

Fix stage finalize output rehydration#216

Merged
MaxGhenis merged 1 commit into
mainfrom
codex/fix-stage9-manifest-roundtrip-20260604
Jun 4, 2026
Merged

Fix stage finalize output rehydration#216
MaxGhenis merged 1 commit into
mainfrom
codex/fix-stage9-manifest-roundtrip-20260604

Conversation

@MaxGhenis
Copy link
Copy Markdown
Contributor

Summary

  • rehydrate serialized stage outputs during final artifact-manifest finalization
  • allow a previously failed finalize to become complete when required outputs are present on disk
  • add a regression covering a failed stage-09 manifest with persisted validation evidence and benchmark summary

Root cause

The H5 and stage-09 outputs were written, but finalize reconstructed typed outputs from the artifact manifest and dropped the serialized benchmark_summary already present in stage_artifacts/manifests/09_validation_benchmarking.json. The stage validator then saw an empty structured output and raised even though the output existed on disk.

Validation

  • UV_PROJECT_ENVIRONMENT=.venv313 uv run --python 3.13 --extra dev --extra policyengine python -m ruff check src/microplex_us/pipelines/stage_runtime.py tests/pipelines/test_stage_runtime.py
  • UV_PROJECT_ENVIRONMENT=.venv313 uv run --python 3.13 --extra dev --extra policyengine python -m pytest tests/pipelines/test_stage_runtime.py tests/pipelines/test_stage_run.py -q

Artifact recovery

Applied the fix locally to the existing target_source_gaps_a1f19e0 version directory; stage 09 now has complete: true, lifecycleStatus: complete, and no missing required outputs without rerunning the build.

@MaxGhenis MaxGhenis merged commit d3b5e82 into main Jun 4, 2026
5 checks passed
@MaxGhenis MaxGhenis deleted the codex/fix-stage9-manifest-roundtrip-20260604 branch June 4, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant