Preserve IRA support in CPS retirement split#217
Merged
Conversation
d7b856c to
08a9fc1
Compare
08a9fc1 to
fdc79fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The #214 source-population patch added desired IRA and 401(k) leaves, but the final capped exports still consumed the bundled CPS RETCB total in greedy account order. For typical RETCB values below the 401(k) limit, traditional 401(k) absorbed the whole amount and left both IRA exports at zero, causing export support parity to fail against eCPS.
The landed
a1f19e0checkpoints already contain nonzero desired IRA leaves, so the export normalizer also needs to rebuild final retirement inputs from desired leaves when exporting from those checkpoints; otherwise a checkpoint resume would keep the stale zero final columns.Validation
UV_PROJECT_ENVIRONMENT=.venv313 uv run --python 3.13 --extra dev --extra policyengine python -m pytest tests/data_sources/test_cps_retirement_contributions.py -qUV_PROJECT_ENVIRONMENT=.venv313 uv run --python 3.13 --extra dev --extra policyengine python -m pytest tests/policyengine/test_us.py -q -k 'retirement or persisted_computed_inputs'UV_PROJECT_ENVIRONMENT=.venv313 uv run --python 3.13 --extra dev --extra policyengine python -m pytest tests/targets/test_arch.py::test_arch_target_gap_queue_points_retirement_contributions_to_soi -qUV_PROJECT_ENVIRONMENT=.venv313 uv run --python 3.13 --extra dev --extra policyengine python -m ruff check src/microplex_us/data_sources/cps.py src/microplex_us/pipelines/us.py tests/data_sources/test_cps_retirement_contributions.py tests/policyengine/test_us.py