Stage 3: deploy FastAPI shell as Cloud Run candidate#3649
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3649 +/- ##
==========================================
+ Coverage 78.89% 78.98% +0.09%
==========================================
Files 72 72
Lines 4241 4269 +28
Branches 787 790 +3
==========================================
+ Hits 3346 3372 +26
- Misses 691 693 +2
Partials 204 204 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3648
Summary
policyengine_api.asgi:app.Validation
FLASK_DEBUG=1 .venv/bin/python -m pytest tests/unit/test_cloud_run_deploy_scripts.py -qFLASK_DEBUG=1 .venv/bin/python -m pytest tests/unit/test_asgi_factory.py::test_public_simulation_gateway_health_probe_checks_gateway -qFLASK_DEBUG=1 .venv/bin/python -m pytest tests/unit/test_asgi_factory.py::test_public_simulation_gateway_health_probe_reports_failure -qruff check policyengine_api/asgi_factory.py tests/unit/test_asgi_factory.py tests/unit/test_cloud_run_deploy_scripts.pybash -n .github/scripts/deploy_cloud_run_candidate.shgit diff --checkNotes
The Cloud Run service URL becomes live after candidate validation, but this does not migrate the public App Engine/custom API URL. The existing untracked
markdowns/folder is not part of this PR.