Skip to content

ci: support no-checkout release approval notices#53

Merged
cat-ph merged 2 commits into
mainfrom
codex/notify-approval-no-checkout
Jun 5, 2026
Merged

ci: support no-checkout release approval notices#53
cat-ph merged 2 commits into
mainfrom
codex/notify-approval-no-checkout

Conversation

@cat-ph
Copy link
Copy Markdown
Contributor

@cat-ph cat-ph commented Jun 5, 2026

Summary

  • keep the release approval Slack workflow's existing checkout behavior by default
  • add an opt-in no-checkout compare URL path for callers with version-sortable tag patterns
  • require tag_sort=version when checkout_repository=false, because remote creatordate sorting is not compatible with standalone SDK repos

Why

PostHog/posthog release-cli approval notification spent 11m29s in checkout because actions/checkout fetched every branch and tag from the monorepo. The Slack notification only needs a compare URL, but other SDK release workflows still rely on the existing checkout-based latest-tag behavior.

Compatibility

Audited local SDK callers: posthog-ruby, posthog-go, posthog-php, posthog-python, posthog-ios, posthog-rs, posthog-android, posthog-dotnet, posthog-elixir, and posthog-js.

Default behavior remains checkout_repository=true, so existing @main and pinned callers keep the old full-checkout tag lookup semantics.

Test Plan

  • actionlint .github/workflows/notify-approval-needed.yml
  • python3 YAML parse for .github/workflows/notify-approval-needed.yml
  • verified checkout_repository=false with tag_pattern=posthog-cli/v* and tag_sort=version returns posthog-cli/v0.7.20 and master without checkout
  • verified checkout_repository=false with tag_sort=creatordate fails loudly
  • verified GitHub compare accepts posthog-cli/v0.7.20...master

@cat-ph cat-ph changed the title ci: avoid checkout in release approval notice ci: support no-checkout release approval notices Jun 5, 2026
@cat-ph cat-ph marked this pull request as ready for review June 5, 2026 14:42
@cat-ph cat-ph requested a review from a team as a code owner June 5, 2026 14:42
@cat-ph cat-ph requested a review from a team June 5, 2026 14:43
@cat-ph cat-ph enabled auto-merge (squash) June 5, 2026 15:34
@cat-ph cat-ph merged commit 0356543 into main Jun 5, 2026
14 checks passed
@cat-ph cat-ph deleted the codex/notify-approval-no-checkout branch June 5, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants