Repository navigation
Add upload-chain to start a job from a previous job's finished output - #15
Merged
Merged
Conversation
New `partforge upload-chain -source-job-id=<job>` registers each finished artifact of a fully finished job as a READY source part of a new job. Only manifests are written; the new manifest field `source_finished_key` points at the parent's finished prefix, and workers download and attach every part tarball in it before running the new insert-select. The new job's source table and schema are the parent job's destination table and schema. Multi-part chained sources fall back to a single unchunked insert because _part_offset chunk ranges only partition one part. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New command
partforge upload-chain -source-job-id=<finished-job-id>that starts a new job whose source is the finished output of a previous job.manifest.jsonis uploaded per part (no data copy). New manifest fields3.source_finished_keypoints at the parent's finished prefix.FROMthe parent's destination table.-clickhouse-builddefaults to the parent job's build;-copy-sql-from-jobis supported.Why
Lets a second rewrite run over an earlier rewrite's output without importing into ClickHouse and re-freezing.
Reviewer notes
SUPERSEDEDrowsFINISHED/IMPORTING/IMPORTED); otherwise the command fails with per-status counts._part_offsetranges only partition a single part) and runs one insert. Single-part sources behave as before.delete-job -delete-s3,reset-job, orreset-compactionon the parent before the chained job finishes rewriting will break it. This is documented, not enforced.Testing
go mod tidy,go test ./...pass../e2e/run.shpasses. New step chainse2e-jobintodst.events_v3, verifies no source data was copied, runs workers, imports, and diffs againste2e/expected-chain.tsv.🤖 Generated with Claude Code