ci: skip flags project board workflow for Dependabot PRs#652
Merged
Conversation
The reusable PostHog/.github flags-project-board workflow generates a GitHub App token as its first step. Dependabot-triggered runs execute in a restricted secret context that has no access to the App credentials, so that step hard-fails with "The 'client-id' (or deprecated 'app-id') input must be set to a non-empty string" on every dependency-bump PR (failing since the 2025-09-09 PAT -> GitHub App migration upstream). Guard the job with github.actor != 'dependabot[bot]'. A job-level if reports as skipped, which branch protection treats as non-blocking, so it won't leave a "waiting for status" check. Adding the App secret to the Dependabot context would also work but would hand an org-write key to the untrusted Dependabot context, so the skip is the safer fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Contributor
|
Reviews (1): Last reviewed commit: "ci: skip flags project board workflow fo..." | Re-trigger Greptile |
Contributor
posthog-python Compliance ReportDate: 2026-06-04 19:59:07 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
dustinbyrne
approved these changes
Jun 4, 2026
Co-authored-by: Dustin Byrne <dustin@posthog.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
call-flags-project / add-to-project-boardcheck fails on every Dependabot PR, and has been doing so since ~2026-05-08. Currently-failing examples:The reusable
PostHog/.githubflags-project-board workflow generates a GitHub App token as its first, unconditional step:Dependabot-triggered workflow runs execute in a restricted secret context (GitHub deliberately withholds normal Actions/org secrets from Dependabot to limit supply-chain blast radius). So those secrets resolve to empty and the step hard-fails:
This has been red on every dependency bump since the upstream 2025-09-09 "Migrate from PAT to GitHub App authentication" change.
Fix
Guard the job with
github.actor != 'dependabot[bot]'.PROJECT_BOARD_BOT_APP_ID/PRIVATE_KEYto Dependabot secrets would also fix it, but would hand an org-write GitHub App key to the untrusted Dependabot context — exactly what GitHub's secret isolation protects against.ifreports the check as skipped, which branch protection treats as non-blocking (unlike a workflow-levelpaths/trigger filter, which can leave a check stuck "waiting for status").