Repository navigation
Revert "Platform-aware Install-PSResource: filter runtimes by RID, li… - #2070
Merged
Merged
Conversation
alerickson
requested review from
Sydney Smith (SydneyhSmith),
Aditya Patwardhan (adityapatwardhan),
Anam Navied (anamnavi) and
shammu1
as code owners
October 19, 2026 20:49
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟡 Changes recommended
Remaining references to deleted fields block compilation, and the CI reversions undo authentication and cleanup fixes.
3 open issues
What changed in this PR
Reverts platform-aware installation from #1963 to address module-loading failures in Windows PowerShell, including Az.Accounts.
Changes:
- Removes runtime/framework filtering, override parameters, and merge installation.
- Restores previous dependency handling and removes related helpers and tests.
- Reverts two independent CI fixes.
| File | Description |
|---|---|
| test/PSResourceInfo.Tests.ps1 | Removes empty dependency-group coverage. |
| test/PlatformFilteringTests/RuntimePackageHelper.Tests.ps1 | Deletes runtime asset tests. |
| test/PlatformFilteringTests/RuntimeIdentifierHelper.Tests.ps1 | Deletes runtime compatibility tests. |
| test/PlatformFilteringTests/PlatformAwareInstall.Tests.ps1 | Deletes platform-aware installation tests. |
| src/code/Utils.cs | Removes directory merging helper. |
| src/code/RuntimePackageHelper.cs | Deletes runtime asset filtering helper. |
| src/code/RuntimeIdentifierHelper.cs | Deletes runtime detection helper. |
| src/code/PSResourceInfo.cs | Restores previous dependency parsing. |
| src/code/InternalHooks.cs | Removes platform test hooks. |
| src/code/InstallPSResource.cs | Removes platform override parameters. |
| src/code/InstallHelper.cs | Removes filtering and merge behavior. |
| src/code/ArgumentCompleter.cs | Removes platform parameter completions. |
| .ci/test.yml | Removes token fallback and cleanup shell selection. |
Review effort: Balanced
Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Add check for GITHUB_TOKEN before removing Authorization header Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Anam Navied (anamnavi)
approved these changes
Oct 19, 2026
Aditya Patwardhan (adityapatwardhan)
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

…bs by TFM (#1963)"
This reverts commit 156083a.
PR Summary
Reverts PR: #1963
due to issues with loading modules like Az.Accounts in Windows PowerShell.
For example, Az.Accounts in Windows PowerShell needs access to the following directories:

However, PR #1963 only installs the net47 lib directory.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.