Repository navigation
[codex] compact generated cycle tracker state - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shallow
ThrowOnCyclemappings eagerly allocate a HashSet even when only one source is active. Store that first source in one object slot, then promote to reference-identity spill storage for a second simultaneous source and retain it across siblings. Empty/null and reserved sentinel/type-tag sources remain distinct; cycle paths, exception metadata, Enter/finally/Exit cleanup and static generated mapping are unchanged.Adds focused state, collision, identity, failure cleanup, reentrancy and allocation tests, including both simultaneous null/self orderings. Updates existing storage assertions and records measured performance limits. No public API, consumer-skill contract, benchmark harness, threshold or runtime policy change.
Validation
Performance and release boundary
On SPECTRE_GRD, tracked depth-1 allocations fell from 232 to 56 B/op; depths 2/16/128 remain 264/1,744/15,528 B/op. The six-pass three-design timing experiment had control drift up to 94.14%, reversed compact/inline-first shallow ordering, and deeper slowdown signals. All four compact/develop gate comparisons blocked. This establishes an allocation improvement, not an overall throughput win or release performance pass; the earlier 3.0.0/develop shallow timing concern remains unresolved. No measurements from other PCs were pooled.
Full raw evidence: compact experiment archive, SHA256
1D78057FA23247A5A3637132A9B9A5FFBE0A4E445C4C7F4A91588EDA6B995F59. Stable same-binary controls and a final-version nonpublishing release rehearsal remain release gates. Draft for human review; no merge, tag or publication is requested.