Skip to content

Serialize symlink paths - #520

Open
Gautzilla wants to merge 4 commits into
Project-OSmOSE:mainfrom
Gautzilla:serialize-symlink-paths
Open

Gautzilla wants to merge 4 commits into
Project-OSmOSE:mainfrom
Gautzilla:serialize-symlink-paths

Conversation

@Gautzilla

@Gautzilla Gautzilla commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

What's going on?

There was a bug with windows symlinks where relative paths where one has a symlink and the other not didn't were considered not to be relative.

example:

root = Path(r"C:/root")
symlink = Path(r"U:/root") # Symlink to root

_serialize_path(value=symlink/"fun", root_path=root) # returns "U:/root/fun" instead of "fun"

This also led to issues with the path_anchor context:

root = Path(r"C:/root")
symlink = Path(r"U:/root") # Symlink to root

with path_anchor(anchor=root):
	_serialize_path(value=symlink/"fun", root_path=symlink) # returns "U:/root/fun" instead of "fun"

@Gautzilla Gautzilla self-assigned this Oct 21, 2026
@Gautzilla Gautzilla added the Bug Something's fishy label Oct 21, 2026
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 99.015% (+0.08%) from 98.932% — Gautzilla:serialize-symlink-paths into Project-OSmOSE:main

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something's fishy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants