Skip to content

Pet battles: would you take tamer battles and a battle engine, and in what shape? #1628

Open

Description

@icemansparks

Besides the six small pet battle fixes already open (#1617, #1618, #1624, #1625, #1626, #1627), I have a larger set of pet battle work on my fork and would like to know whether you want it here before I open anything.

What it adds on top of main:

  • Tamer battles. The enemy side becomes a team of up to three pets, with its own cooldowns and an ability picker. Tamer teams load from a new world table battle_pet_npc_team, the tamer's gossip option starts the battle, and a battle ends with quest and achievement credit, the forfeit penalty and experience per defeated pet. Beasts of Fable give credit and refuse traps.
  • A battle engine. One effect runner is shared by both sides. On top of it: speed and turn order, type advantage, crits, hit chance and damage variance, auras with their apply and remove packets and per-round turns, crowd control and Resilient, pet states and weather, multi-turn abilities, revive and forced swaps.
  • Unit tests for the battle state and the packets.

The goal throughout was to match retail 5.4.8 as closely as possible. Abilities, numbers and the order things happen in come from our own experience playing pet battles back then, old gameplay footage, and the ability and tamer details on Wowhead.

Against current main this is 12 files with about 8,700 added and 1,400 removed lines, about 4,800 of the added lines being tests, plus one world SQL update for the team table. It is built as about 37 small changes, each on top of the ones before: the engine needs the enemy team, and most of it needs the shared runner. It sits on top of the six open PRs, so those would go in first.

Two questions:

  1. Do you want tamer battles and the engine in this repo?
  2. If yes, how would you like to review it: two squashed PRs (tamer battles, then the engine), or the ordered series of about 37 small PRs, each opened after the previous one is merged?

If you'd rather not have some part of it, for example the new world table or the .battlepet npc GM command, say so and I'll leave it out.

Activity

  1. icemansparks commented on Nov 16, 2026

    @icemansparks
    ContributorAuthor

    One more point for the decision: what the fork does not do yet, so the scope is clear.

    • No Celestial Tournament, and Beasts of Fable fight as a single pet instead of a team.
    • All tamers share one ability picker; there are no per-tamer tactics.
    • Experience sharing between ally pets in tamer battles does not follow a 5.4.8 rule yet.
    • Some crowd control cases are missing, and ability effect 54 ignores its chain-failure, accuracy and max-stack parameters.
    • Effects 85 and 156 have no known meaning and do nothing.
    • The round timer bar in the client never counts down.
    • 13 packet-layout unit tests fail against the current packet code.
    • .battlepet heal and .battlepet levelup find pets only by their English species name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions