[Artifact 0101] グリモワールの作成#2057
Open
ogachu0331 wants to merge 7 commits into
Open
Conversation
Lapis-LJA
requested changes
Jun 14, 2026
Lapis-LJA
left a comment
Lapis-LJA
left a comment
Contributor
There was a problem hiding this comment.
全体的にセレクターにtype=が足りてないので追加してほしい
Comment on lines
+5
to
+6
| # @within function asset:artifact/0101.grimoire/trigger/3.main | ||
| # @within function asset:artifact/0101.grimoire/trigger/balletfire |
Contributor
There was a problem hiding this comment.
こう書いた方がスマートかな～
他の属性もそうしてね
Suggested change
| # @within function asset:artifact/0101.grimoire/trigger/3.main | |
| # @within function asset:artifact/0101.grimoire/trigger/balletfire | |
| # @within function | |
| # asset:artifact/0101.grimoire/trigger/3.main | |
| # asset:artifact/0101.grimoire/trigger/balletfire |
Contributor
There was a problem hiding this comment.
各ballet○○ってやつ、ディレクトリを変えて、ballet/の中にfire, water. thunderを入れる感じにしたほうが良いかも～～
このままだと命名規則にも沿ってないし、やってることは同じだからフォルダにまとめた方がよさげに見える
Comment on lines
+8
to
+12
| particle minecraft:dust 1 0 0 1 | ||
| execute unless block ~ ~ ~ #lib:no_collision/ run return run function asset:artifact/0101.grimoire/trigger/fire | ||
| execute unless entity @s[distance=..10] run return run function asset:artifact/0101.grimoire/trigger/fire | ||
| execute at @e[tag=Enemy,distance=..2,sort=nearest,limit=1] run return run function asset:artifact/0101.grimoire/trigger/fire | ||
| execute positioned ^ ^ ^0.5 run function asset:artifact/0101.grimoire/trigger/balletfire |
Contributor
There was a problem hiding this comment.
意図は伝わるけど...もうちょいコメントは書いたほうが良いかも(
| particle minecraft:dust 1 0 0 1 | ||
| execute unless block ~ ~ ~ #lib:no_collision/ run return run function asset:artifact/0101.grimoire/trigger/fire | ||
| execute unless entity @s[distance=..10] run return run function asset:artifact/0101.grimoire/trigger/fire | ||
| execute at @e[tag=Enemy,distance=..2,sort=nearest,limit=1] run return run function asset:artifact/0101.grimoire/trigger/fire |
Contributor
There was a problem hiding this comment.
at @.eじゃなくて、positioned ~-0.5 ~-0.5 ~-0.5 at @.e[dx=0]ってしたほうが良い
その方が判定が正確になる
それと、セレクターにはtypeを使ってほしい、今回の場合は#lib:living_without_playerかな
| # 着弾処理 | ||
| # | ||
| # @within function asset:artifact/0101.grimoire/trigger/balletfire | ||
| #1840 |
| data modify storage api: Argument.ElementType set value "Water" | ||
| # 補正functionを実行 | ||
| function api:damage/modifier | ||
| # 範囲5m以内の敵を対象に |
Contributor
There was a problem hiding this comment.
コメントが嘘すぎるので、もういっそDamageAPIのコメントは「ダメージ」だけでもいいんじゃないかな
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
スプレッドシートでだれも手を付けず、放置されてるっぽかったので、勝手に作っちゃいました