Repository navigation
Write events as JSCalendar, with account state on every write - #73
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Documentation build overview
12 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67.
create_event,send_invite, andupdate_eventtake a JSCalendar dict now, not an iCalendar string. Reads already hand back JSCalendar, so writing one back no longer goes through iCalendar first and loses properties on the way.create_event/send_invitereturn(event_id, old_state, new_state).update_eventreturns(old_state, new_state). The server was already sendingoldState/newStateon every write, we were just dropping them.Ships without #66. Converters stay where they are.
id,baseEventId, andisOriginget stripped before a write goes out, since the spec marks them server-set and immutable. Stalwart actually enforces that and rejects a write carrying them, Cyrus doesn't, so this had to be handled, not left to one server's leniency.