Repository navigation
Fix stale sync docs still showing the old 4-tuple return - #74
Merged
Merged
Conversation
Documentation build overview
4 files changed± how-to/errors.html± how-to/example-sync-cache.html± how-to/sync.html± reference/index.html |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/how-to/sync.rstanddocs/how-to/example-sync-cache.rststill unpackedget_objects_by_sync_tokeninto a 4-tuple and described the removedserverPartialFailexception, left over from before #69/#71 changed the return shape to a 6-tuple with paging.Fixed both to unpack
(added, modified, deleted, old_state, new_state, has_more_changes)and loop onhas_more_changesinstead of catching an error that no longer gets raised.The sync-cache example also keyed its sync token by calendar id, which was always wrong. JMAP state covers the whole account, not one calendar; fixed to key it by account, with a single-row table instead of one row per calendar.