Repository navigation
Roadmap 1.4: Workspace.from_config() and the shared config file - #12
Merged
Merged
Conversation
from_config() reads the configuration file shared with caldav and calendaring-jmap through the new calendaring-config package, and makes one backend per section, named after it. It has to await connect(), so in async mode it is now a coroutine; API_DESIGN §2.1 says so. Any problem with the file, or with connecting a section, is a ConfigurationError naming the section, and the backends already connected are closed. Prompt: (Discussions with Claude on how to deal with the configuration - it was decided to move the logic to a separate package) Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
The configuration proposal said calendaring already depends on caldav, which was wrong, and left the parser's home open. It now lives in calendaring-config, released at calendaring's pace rather than caldav's. Roadmap 1.4 is ticked except for settling the file with caldav, which has yet to adopt the package. Prompt: (Discussions with Claude on how to deal with the configuration - it was decided to move the logic to a separate package) Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: Code and the text below the line are AI-generated, by Claude Opus 5.5
Implements roadmap item 1.4. The parser for the configuration file shared with caldav and calendaring-jmap now lives in its own package, calendaring-config (0.1.0 is on PyPI). Its
docs/format.mdspecifies the format. Putting the parser in caldav (option B) would have made calendaring depend on caldav, and would have tied every config change to a caldav release.Workspace.from_config()makes one backend per section, with the section name as its id (environment-<kind>for a connection from the environment). Any problem with the file, or with connecting a section, is aConfigurationErrornaming the section, and the backends already connected are closed. In async mode it is a coroutine, since it awaitsconnect().CONFIGURATION_PROPOSAL.mdrecords option C. ROADMAP 1.4 is ticked except for settling the file with caldav: Use the shared calendaring-config parser for the configuration file python-caldav/caldav#786. API_DESIGN §2.2 leaves open which keys a backend ignores, to be decided with the CalDAV backend (2.1).🤖 Generated with Claude Code