Repository navigation
SOGo: calendaring's part of the conformance fixes - #28
Merged
Merged
Conversation
test_time_spent_in_a_meeting compared the meeting as sent with the meeting as stored, so it failed on SOGo, which adds CLASS:PUBLIC to everything it stores. It now compares the stored meeting before and after log_time(), which is what the test is about. Prompt: (Claude ran tests and made a list of SOGo failures): This should be fixed, not filed. Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
A server that spells out an RFC 5545 parameter default, as SOGo does with PARTSTAT=NEEDS-ACTION on each ATTENDEE, has changed nothing, but verify=True reported it. Parameters are now compared in any order and without those at their default; RSVP=TRUE, which SOGo also adds, is a real change and is still reported. Prompt: (Claude ran tests and made a list of SOGo failures): This should be fixed, not filed. Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
create_collection() raised nothing when the collection it made could hold none of the requested components: a tracker made an empty one, and Bedework makes events-only calendars whatever is asked. Such a collection is now refused, and deleted again where it can be; one that cannot be is named in the error. Where caldav knows the server ignores the requested component set (SOGo, Bedework 5, GMX), create-collection is declared LOSSY, and the conformance suite accepts a calendar holding more than asked, or the refusal. Prompt: (Claude ran tests and made a list of SOGo failures): This should be fixed, not filed. Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Member
Author
|
Disclaimer: AI-generated text, by Claude Opus 5.5. Folded into #27: the same three commits, fast-forwarded onto its branch, since both are roadmap 3.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: The code and the text below the line are AI-generated, by Claude Opus 5.5, from the prompt:
The conformance suite failed 6 tests on SOGo. This PR fixes calendaring's part, and 4 failures remain. Each of those waits on caldav: a new hint, or a check for an existing object at the URL in
save(no_overwrite=True).CLASS:PUBLIC. It now compares the stored meeting before and afterlog_time().verifyignores parameters at their RFC 5545 default, and parameter order. SOGo spells outPARTSTAT=NEEDS-ACTION. TheRSVP=TRUEit also adds is still reported, as a real change.create_collection()refuses a collection that would hold none of the requested components. Where it was made anyway, it is deleted again (Bedework makes events-only calendars whatever is asked). Where caldav says the server ignores the component set (SOGo, Bedework 5, GMX),create-collectionis declaredLOSSY. This also covers the memory TRACKER profile, which used to make an empty collection.