Repository navigation
fix: no OverflowError at the datetime range ends - #22
Merged
Merged
Conversation
Within a day of datetime.min / datetime.max, a value cannot be moved into the process or a pytz time zone (OverflowError, or ValueError for naive values), nor shifted by a duration. So a full-range search failed outside UTC, and one component dated in year 1 or 9999 broke every time-range search over its calendar. Keep such values in their own time zone and saturate the arithmetic. When a search bound is near an end, narrow the recurrence expansion window by the longest occurrence plus a day; ordinary searches are expanded as before. Fixes #19 Prompt: What? Issue #19 sounds serious ... [based on a quick reading of the title alone, in shock since I just released 1.2.0 - however, this is not a bug impacting real world users] Followup-Prompt: Just make a PR and skip releasing 1.2.1 as for now Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
Within a day of datetime.min / datetime.max, a value cannot be moved
into the process or a pytz time zone (OverflowError, or ValueError for
naive values), nor shifted by a duration. So a full-range search
failed outside UTC, and one component dated in year 1 or 9999 broke
every time-range search over its calendar. Keep such values in their
own time zone and saturate the arithmetic. When a search bound is
near an end, narrow the recurrence expansion window by the longest
occurrence plus a day; ordinary searches are expanded as before.
Fixes #19
Prompt: What? Issue #19 sounds serious ... [based on a quick reading of the title alone, in shock since I just released 1.2.0 - however, this is not a bug impacting real world users]
Followup-Prompt: Just make a PR and skip releasing 1.2.1 as for now
Assisted-By: Claude Opus 5.5 (1M context) noreply@anthropic.com
Reviewed-by: Tobias Brox tobias@redpill-linpro.com
🤖 Generated with Claude Code