Repository navigation
fix: treat an RDATE-only component as recurring - #25
Merged
Merged
Conversation
Only a component with RRULE counted as a recurrence master. An RDATE-only master with a RECURRENCE-ID override made check_component() raise "Expected a valid recurrence set", breaking every search over its calendar. Without overrides, the RDATE occurrences were never expanded, so time-range searches missed them. Prompt: Please fix the icalendar-searcher bug [an RDATE series with an override breaks search, found in a review of https://github.com/pycalendar/calendaring] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
fix: treat an RDATE-only component as recurring
Only a component with RRULE counted as a recurrence master. An
RDATE-only master with a RECURRENCE-ID override made check_component()
raise "Expected a valid recurrence set", breaking every search over its
calendar. Without overrides, the RDATE occurrences were never
expanded, so time-range searches missed them.
Prompt: Please fix the icalendar-searcher bug [an RDATE series with an override breaks search, found in a review of https://github.com/pycalendar/calendaring]
Assisted-By: Claude Opus 5.5 (1M context) noreply@anthropic.com
🤖 Generated with Claude Code