Repository navigation
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds a standalone console project that installs ChromaDB.NET from the freshly-built NuGet package (via a local feed), then exercises the full lifecycle: client creation, heartbeat, collection CRUD, query, and delete. This runs on all three platforms (Linux, Windows, macOS ARM64) after pack_nuget, testing the real NuGet runtimes/ native lib resolution path that consumers use — unlike the unit tests which copy the native lib directly into the output directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR improves build reproducibility and adds CI validation that the produced NuGet package can be installed and exercised end-to-end across supported OSes.
Changes:
- Removed
Cargo.lockfrom.gitignoreso it can be checked in and used for reproducible Rust/native builds. - Added a new
Tests/NuGetSmokeTestconsole app that runs a basic lifecycle againstChromaDB.NET(client creation, heartbeat, collection CRUD, query). - Extended the NuGet build workflow with a cross-platform
smoke_testjob that installs the freshly built.nupkgfrom a local feed and runs the console app.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Tests/NuGetSmokeTest/Program.cs |
Implements the smoke-test lifecycle using the public ChromaDB.NET API. |
Tests/NuGetSmokeTest/NuGetSmokeTest.csproj |
Adds a standalone executable project intended to have ChromaDB.NET installed via CI (not a project reference). |
.gitignore |
Stops ignoring Cargo.lock to allow lockfile tracking. |
.github/workflows/build-nuget.yaml |
Adds a smoke_test matrix job (Linux/Windows/macOS) that installs from the locally built package artifact and runs the smoke test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignoreso CI and local builds use identical dependency versions.nupkgvia a local feed, then exercises the full lifecycle (client, heartbeat, collection CRUD, query, delete) on all 3 platforms (Linux, Windows, macOS ARM64)Test plan
smoke_testjob passes on all 3 platform matrix entriesbuild_nativeandpack_nugetjobs unaffectedcargo buildlocally produces identical results with tracked Cargo.lock🤖 Generated with Claude Code