Skip to content

Bump CI to TheRock 7.13#4952

Open
causten wants to merge 9 commits into
developfrom
bumpci7_13
Open

Bump CI to TheRock 7.13#4952
causten wants to merge 9 commits into
developfrom
bumpci7_13

Conversation

@causten

@causten causten commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Move CI to TheRock 7.13

Technical Details

Changes were significant enough to just rename original files to legacy and add the 7.13 to the default files

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

@causten causten requested a review from a team as a code owner June 10, 2026 16:46
Copilot AI review requested due to automatic review settings June 10, 2026 16:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves MIGraphX’s CI and default Docker build environment to ROCm “TheRock” multi-arch (amdrocm-*) packages targeting ROCm 7.13, while preserving older ROCm (7.2.x and earlier) flows via “legacy” Dockerfiles.

Changes:

  • Added a cross-distro tools/install_build_prereqs.sh to install build prerequisites + TheRock ROCm components (optionally via wheels).
  • Updated CI image Dockerfile (hip-clang.docker) and the default Dockerfile to use Ubuntu 24.04 + ROCm 7.13 TheRock packages.
  • Introduced legacy Dockerfiles and updated docs/changelog to reflect the new default and legacy paths.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tools/install_build_prereqs.sh New shared installer script for build prerequisites and ROCm TheRock components.
tools/docker/therock_deb.docker Removed older TheRock deb-based Dockerfile (replaced by new defaults/legacy split).
tools/docker/legacy.dockerfile Added legacy dev Dockerfile for ROCm 7.2.x and older.
README.md Updated Docker build instructions and documented legacy Dockerfile usage.
hip-clang.docker Updated CI image to Ubuntu 24.04 + ROCm 7.13 TheRock, and prebuilds deps via rbuild.
hip-clang-legacy.docker Added legacy CI image Dockerfile (older ROCm packaging).
Dockerfile Updated default dev Dockerfile to Ubuntu 24.04 + ROCm 7.13 TheRock using the shared prereqs script.
CHANGELOG.md Added entry for ROCm 7.13/TheRock build support.
.github/workflows/ci.yaml Updated CI image tag hashing inputs to reflect the new prereqs script.

Comment thread tools/install_build_prereqs.sh Outdated
Comment thread tools/install_build_prereqs.sh Outdated
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread hip-clang.docker
Comment thread CHANGELOG.md
Comment thread README.md Outdated
Comment thread tools/docker/hip-clang-legacy.docker
Comment thread hip-clang.docker Outdated
Comment thread hip-clang.docker Outdated
Comment thread hip-clang.docker Outdated
Comment thread hip-clang.docker Outdated
Comment thread hip-clang.docker Outdated

@pfultz2 pfultz2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AI generated dockers are really awful and should be simplified and made more readable like the original dockers. Too many commands put into the same line.

Also, this is missing the update to the SLES docker.

Comment thread hip-clang.docker Outdated
Comment thread tools/install_build_prereqs.sh Outdated
Comment thread tools/install_build_prereqs.sh Outdated
Comment thread Dockerfile
hipsparselt \
half \
libssl-dev \
zlib1g-dev && \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing packages here, like clang-17.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While checking the ASAN issue I'm going to go with a suggested workaround using the clang version provided by TheRock since clang-17 didn't have a fix. runtime ASAN_OPTIONS=detect_odr_violation=0, or compile-time -mllvm -asan-use-private-alias=1 + use_odr_indicator=1.

Comment thread Dockerfile
Comment thread Dockerfile
Comment thread Dockerfile
@causten causten changed the title Bumpci7 13 Bump CI to TheRock 7.13 Jun 11, 2026
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4952      +/-   ##
===========================================
+ Coverage    92.71%   92.72%   +0.01%     
===========================================
  Files          589      590       +1     
  Lines        31160    31233      +73     
===========================================
+ Hits         28888    28960      +72     
- Misses        2272     2273       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Comment thread .github/workflows/ci.yaml Outdated
Comment thread tools/install_prereqs.sh
Comment thread hip-clang.docker
Comment thread tools/install_prereqs.sh Outdated
Comment thread Dockerfile
Comment on lines +93 to +95
ADD tools/requirements-py.txt /requirements-py.txt
RUN CMAKE_ARGS="-DONNX_USE_PROTOBUF_SHARED_LIBS=ON" pip3 install -r /requirements-py.txt && \
rm /requirements-py.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants