Skip to content

Commit 174ecfa

Browse files
authored
Merge pull request #267 from schwabe/patch-1
Fix misleading comment with fingerprint hash weaker than a certificat…
2 parents 05611bb + 5eaad0a commit 174ecfa

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,8 @@ This is the ``settings.json`` file:
323323
/*
324324
* Instead of using the whole X.509cert you can use a fingerprint in order to
325325
* validate a SAMLResponse (but you still need the X.509cert to validate LogoutRequest and LogoutResponse using the HTTP-Redirect binding).
326-
* But take in mind that the fingerprint, is a hash, so at the end is open to a collision attack that can end on a signature validation bypass,
327-
* that why we don't recommend it use for production environments.
326+
* But take in mind that the algortithm for the fingerprint should be as strong as the algorithm in a normal certificate signature
327+
* (e.g. SHA256 or strong)
328328
*
329329
* (openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
330330
* or add for example the -sha256 , -sha384 or -sha512 parameter)

0 commit comments

Comments
 (0)