Fix all cases of frozen strings

Author: johnnyshields

lib/onelogin/ruby-saml/authrequest.rb

@@ -39,7 +39,7 @@ def create(settings, params = {})
         params = create_params(settings, params)
         params_prefix = (settings.idp_sso_service_url =~ /\?/) ? '&' : '?'
         saml_request = CGI.escape(params.delete("SAMLRequest"))
-        request_params = "#{params_prefix}SAMLRequest=#{saml_request}"
+        request_params = +"#{params_prefix}SAMLRequest=#{saml_request}"
         params.each_pair do |key, value|
           request_params << "&#{key}=#{CGI.escape(value.to_s)}"
         end
@@ -66,7 +66,7 @@ def create_params(settings, params={})
         request_doc = create_authentication_xml_doc(settings)
         request_doc.context[:attribute_quote] = :quote if settings.double_quote_xml_attribute_values
 
-        request = ""
+        request = +""
         request_doc.write(request)
 
         Logging.debug "Created AuthnRequest: #{request}"

lib/onelogin/ruby-saml/logoutrequest.rb

@@ -36,7 +36,7 @@ def create(settings, params={})
         params = create_params(settings, params)
         params_prefix = (settings.idp_slo_service_url =~ /\?/) ? '&' : '?'
         saml_request = CGI.escape(params.delete("SAMLRequest"))
-        request_params = "#{params_prefix}SAMLRequest=#{saml_request}"
+        request_params = +"#{params_prefix}SAMLRequest=#{saml_request}"
         params.each_pair do |key, value|
           request_params << "&#{key}=#{CGI.escape(value.to_s)}"
         end
@@ -63,7 +63,7 @@ def create_params(settings, params={})
         request_doc = create_logout_request_xml_doc(settings)
         request_doc.context[:attribute_quote] = :quote if settings.double_quote_xml_attribute_values
 
-        request = ""
+        request = +""
         request_doc.write(request)
 
         Logging.debug "Created SLO Logout Request: #{request}"

lib/onelogin/ruby-saml/metadata.rb

@@ -163,7 +163,7 @@ def embed_signature(meta_doc, settings)
       end
 
       def output_xml(meta_doc, pretty_print)
-        ret = ''
+        ret = +''
 
         # pretty print the XML so IdP administrators can easily see what the SP supports
         if pretty_print

lib/onelogin/ruby-saml/slo_logoutresponse.rb

@@ -41,7 +41,7 @@ def create(settings, request_id = nil, logout_message = nil, params = {}, logout
         params_prefix = (settings.idp_slo_service_url =~ /\?/) ? '&' : '?'
         url = settings.idp_slo_response_service_url || settings.idp_slo_service_url
         saml_response = CGI.escape(params.delete("SAMLResponse"))
-        response_params = "#{params_prefix}SAMLResponse=#{saml_response}"
+        response_params = +"#{params_prefix}SAMLResponse=#{saml_response}"
         params.each_pair do |key, value|
           response_params << "&#{key}=#{CGI.escape(value.to_s)}"
         end
@@ -72,7 +72,7 @@ def create_params(settings, request_id = nil, logout_message = nil, params = {},
         response_doc = create_logout_response_xml_doc(settings, request_id, logout_message, logout_status_code)
         response_doc.context[:attribute_quote] = :quote if settings.double_quote_xml_attribute_values
 
-        response = ""
+        response = +""
         response_doc.write(response)
 
         Logging.debug "Created SLO Logout Response: #{response}"

lib/onelogin/ruby-saml/utils.rb

@@ -28,7 +28,7 @@ class Utils
           (\d+)W                    # 8: Weeks
         )
       $)x.freeze
-      UUID_PREFIX = '_'
+      UUID_PREFIX = +'_'
 
       # Checks if the x509 cert provided is expired
       #
@@ -134,7 +134,7 @@ def self.format_private_key(key)
       def self.build_query(params)
         type, data, relay_state, sig_alg = [:type, :data, :relay_state, :sig_alg].map { |k| params[k]}
 
-        url_string = "#{type}=#{CGI.escape(data)}"
+        url_string = +"#{type}=#{CGI.escape(data)}"
         url_string << "&RelayState=#{CGI.escape(relay_state)}" if relay_state
         url_string << "&SigAlg=#{CGI.escape(sig_alg)}"
       end
@@ -151,7 +151,7 @@ def self.build_query(params)
       def self.build_query_from_raw_parts(params)
         type, raw_data, raw_relay_state, raw_sig_alg = [:type, :raw_data, :raw_relay_state, :raw_sig_alg].map { |k| params[k]}
 
-        url_string = "#{type}=#{raw_data}"
+        url_string = +"#{type}=#{raw_data}"
         url_string << "&RelayState=#{raw_relay_state}" if raw_relay_state
         url_string << "&SigAlg=#{raw_sig_alg}"
       end
@@ -211,7 +211,7 @@ def self.verify_signature(params)
       # @return [String] The status error message
       def self.status_error_msg(error_msg, raw_status_code = nil, status_message = nil)
         unless raw_status_code.nil?
-          if raw_status_code.include? "|"
+          if raw_status_code.include?("|")
             status_codes = raw_status_code.split(' | ')
             values = status_codes.collect do |status_code|
               status_code.split(':').last
@@ -220,11 +220,11 @@ def self.status_error_msg(error_msg, raw_status_code = nil, status_message = nil
           else
             printable_code = raw_status_code.split(':').last
           end
-          error_msg << ', was ' + printable_code
+          error_msg += ', was ' + printable_code
         end
 
         unless status_message.nil?
-          error_msg << ' -> ' + status_message
+          error_msg += ' -> ' + status_message
         end
 
         error_msg