fixing errors: Robot file to add new "headless" argument; updating selenium methods: find_elements_by_xpath to find_elements

Author: arvindbhamidipati

cumulusci/robotframework/Salesforce.py

@@ -12,6 +12,7 @@
     StaleElementReferenceException,
     WebDriverException,
 )
+from selenium.webdriver.common.by import By
 from selenium.webdriver.common.action_chains import ActionChains
 from selenium.webdriver.common.keys import Keys
 from SeleniumLibrary.errors import ElementNotFound, NoOpenBrowser
@@ -892,7 +893,8 @@ def _locate_element_by_label(self, browser, locator, tag, constraints):
             fieldset_prefix
             + f'//label[descendant-or-self::*[text()[normalize-space() = "{label}"]]]'
         )
-        labels = browser.find_elements_by_xpath(label_xpath)
+        labels = browser.find_elements(By.XPATH, label_xpath)
+
         if not labels:
             return []
 

cumulusci/robotframework/Salesforce.robot

@@ -186,7 +186,7 @@ Chrome Set Headless
     ...  This keyword is not intended to be used by test scripts
 
     [Arguments]  ${options}
-    Call Method  ${options}  set_headless  ${true}
+    Call Method  ${options}  add_argument  --headless
     Call Method  ${options}  add_argument  --disable-dev-shm-usage
     Call Method  ${options}  add_argument  --disable-background-timer-throttling
     [return]  ${options}

cumulusci/robotframework/form_handlers.py

@@ -2,6 +2,7 @@
 
 from robot.libraries.BuiltIn import BuiltIn
 from selenium.common.exceptions import TimeoutException
+from selenium.webdriver.common.by import By
 
 from cumulusci.utils.classutils import get_all_subclasses
 
@@ -61,9 +62,7 @@ def selenium(self):
     @property
     def input_element(self):
         """Returns the first <input> or <textarea> element inside the element"""
-        elements = self.element.find_elements_by_xpath(
-            ".//*[self::input or self::textarea]"
-        )
+        elements = self.element.find_elements(By.XPATH, ".//*[self::input or self::textarea]")
         return elements[0] if elements else None
 
     @abc.abstractmethod
@@ -130,9 +129,8 @@ class LightningComboboxHandler(BaseFormHandler):
     @property
     def input_element(self):
         """Returns the base form element (input or button) that the combobox is based on"""
-        elements = self.element.find_elements_by_xpath(
-            ".//*[contains(@class, 'slds-combobox__input')]"
-        )
+        elements = self.element.find_elements(By.XPATH, ".//*[contains(@class, 'slds-combobox__input')]")
+        
         return elements[0] if elements else None
 
     def set(self, value):

cumulusci/robotframework/pageobjects/BasePageObjects.py

@@ -13,6 +13,8 @@
 
 from selenium.common.exceptions import NoSuchElementException, TimeoutException
 from SeleniumLibrary.errors import ElementNotFound
+from selenium.webdriver.common.by import By
+
 
 from cumulusci.robotframework.form_handlers import get_form_handler
 from cumulusci.robotframework.pageobjects import BasePage, pageobject
@@ -261,7 +263,8 @@ def _get_form_element_for_label(self, label):
 
             # also, we use find_elements (plural) here because it will
             # return an empty list rather than throwing an error
-            modals = root.find_elements_by_xpath("//div[contains(@class, 'uiModal')]")
+            # modals = root.find_elements_by_xpath("//div[contains(@class, 'uiModal')]")
+            modals = root.find_element(By.XPATH, "//div[contains(@class, 'uiModal')]")
             # There should only ever be zero or one, but the Salesforce
             # UI never ceases to surprise me.
             modals = [m for m in modals if m.is_displayed()]