fix(robot): make locator version test resilient to new locator files

The test_locators_in_robot_context test hardcoded the expected locator
module name. When not running in a Robot context, the library falls
back to the highest-numbered locator file. Use dynamic discovery
(same pattern as test_locators_outside_robot_context) instead.

Author: jstvz

cumulusci/robotframework/tests/test_salesforce_locators.py

@@ -19,10 +19,14 @@ def test_locators_in_robot_context(self, get_latest_api_version):
         # This instantiates the robot library, mimicking a robot library import.
         # We've mocked out the code that would otherwise throw an error since
         # we're not running in the context of a robot test. The library should
-        # return the latest version of the locators.
+        # fall back to the latest version since the mock doesn't reach the
+        # init path that resolves the API version from the org.
         sf = Salesforce()
 
-        expected = "cumulusci.robotframework.locators_57"
+        locator_folder = Path("./cumulusci/robotframework")
+        locator_modules = sorted(locator_folder.glob("locators_[0-9][0-9].py"))
+        expected = f"cumulusci.robotframework.{locator_modules[-1].stem}"
+
         actual = sf.locators_module.__name__
         message = "expected to load '{}', actually loaded '{}'".format(expected, actual)
         assert expected == actual, message