W-18185062#3891
Merged
jstvz merged 1 commit intoSFDO-Tooling:mainfrom Apr 9, 2025
Merged
Conversation
Contributor
dcinzona
commented
Apr 3, 2025
dcinzona
commented
- Setting latex engine to help with ReadTheDocs PDF generation (missing unicode characters using default engine)
- Fixing Pygments errors for robotframework syntax in markdown
- Fixing invalid sample code in robot.md
|
Thanks for the contribution! It looks like @dcinzona is an internal user so signing the CLA is not required. However, we need to confirm this. |
Contributor
Author
|
jstvz
requested changes
Apr 4, 2025
| CumulusCI makes it easy to harness the power of second-generation | ||
| managed packages to implement an advanced, comprehensive testing process | ||
| for both first- and second-generation managed package products. This is | ||
| for both first and second-generation managed package products. This is |
Contributor
There was a problem hiding this comment.
nit: If the hanging hyphen is tripping us up, let's go with the more verbose but still correct:
Suggested change
| for both first and second-generation managed package products. This is | |
| for both first-generation and second-generation managed package products. This is |
|
|
||
| Example: | ||
| ```console | ||
| cci task run extract_dataset -o mapping datasets/qa/mapping.yml -o sql_path datasets/qa/data.sql --org qa |
Contributor
There was a problem hiding this comment.
Suggested change
| cci task run extract_dataset -o mapping datasets/qa/mapping.yml -o sql_path datasets/qa/data.sql --org qa | |
| cci task run extract_dataset -o mapping datasets/qa/mapping.yml -o sql_path datasets/qa/data.sql --org qa |
Comment on lines
-69
to
+83
| ┌Scratch Orgs──────────────┬─────────┬──────┬─────────┬──────────────┬────────┐ | ||
| Scratch Orgs | ||
| │ Name │ Default │ Days │ Expired │ Config │ Domain │ | ||
| ├──────────────────────────┼─────────┼──────┼─────────┼──────────────┼────────┤ | ||
| ├──────────────────────────|─────────|──────|─────────|──────────────|────────-| | ||
| │ dev │ │ 7 │ X | dev │ │ | ||
| ├──────────────────────────┼─────────┼──────┼─────────┼──────────────┼────────┤ | ||
| ├──────────────────────────|─────────|──────|─────────|──────────────|────────-| | ||
| │ feature │ │ 1 │ X | feature │ │ | ||
| ├──────────────────────────┼─────────┼──────┼─────────┼──────────────┼────────┤ | ||
| ├──────────────────────────|─────────|──────|─────────|──────────────|────────-| | ||
| │ prerelease │ │ 1 │ X | prerelease │ │ | ||
| ├──────────────────────────┼─────────┼──────┼─────────┼──────────────┼────────┤ | ||
| ├──────────────────────────|─────────|──────|─────────|──────────────|────────-| | ||
| │ qa │ │ 7 │ X | qa │ │ | ||
| ├──────────────────────────┼─────────┼──────┼─────────┼──────────────┼────────┤ | ||
| ├──────────────────────────|─────────|──────|─────────|──────────────|────────-| | ||
| │ release │ │ 1 │ X | release │ │ | ||
| └──────────────────────────┴─────────┴──────┴─────────┴──────────────┴────────┘ | ||
|
|
||
| ┌Connected Orgs────┬──────────────────────────────┬────────────┐ | ||
|
|
||
| Connected Orgs | ||
| │ Name │ Default │ Username │ Expires │ | ||
| ├────────┼─────────┼──────────────────────────────┼────────────┤ | ||
| ├────────|─────────|──────────────────────────────|────────────-| | ||
| │ devhub │ │ j.holt@mydomain.devhub │ Persistent │ | ||
| └────────┴─────────┴──────────────────────────────┴────────────┘ | ||
|
|
Contributor
There was a problem hiding this comment.
Let's update to match the current output:
$ cci org list
Scratch Orgs
Default Name Days Expired Config Domain
─────────────────────────────────────────────────────────────
beta 1 beta
dev 7 ✔ dev
feature 1 feature
qa 7 ✔ qa
release 1 release
Connected Orgs
Default Name Username Expires
───────────────────────────────────────────────────────────────────────────────────────
devhub j.holt@mydomain.devhub Persistent| CumulusCI makes it easy to harness the power of second-generation | ||
| managed packages to implement an advanced, comprehensive testing process | ||
| for both first- and second-generation managed package products. This is | ||
| for both first and second-generation managed package products. This is |
Contributor
There was a problem hiding this comment.
More verbose, but grammar:
Suggested change
| for both first and second-generation managed package products. This is | |
| for both first-generation and second-generation managed package products. This is |
|
|
||
| Example: | ||
| ```console | ||
| cci task run extract_dataset -o mapping datasets/qa/mapping.yml -o sql_path datasets/qa/data.sql --org qa |
Contributor
There was a problem hiding this comment.
Let's drop leading spaces since we're using fences:
Suggested change
| cci task run extract_dataset -o mapping datasets/qa/mapping.yml -o sql_path datasets/qa/data.sql --org qa | |
| cci task run extract_dataset -o mapping datasets/qa/mapping.yml -o sql_path datasets/qa/data.sql --org qa |
| Example: | ||
|
|
||
| ```console | ||
| cci task run load_dataset -o mapping datasets/qa/mapping.yml -o sql_path datasets/qa/data.sql --org qa |
Contributor
There was a problem hiding this comment.
Suggested change
| cci task run load_dataset -o mapping datasets/qa/mapping.yml -o sql_path datasets/qa/data.sql --org qa | |
| cci task run load_dataset -o mapping datasets/qa/mapping.yml -o sql_path datasets/qa/data.sql --org qa |
| Example: | ||
|
|
||
| ```console | ||
| cci task run generate_dataset_mapping --org qa -o namespace_prefix my_ns |
Contributor
There was a problem hiding this comment.
Suggested change
| cci task run generate_dataset_mapping --org qa -o namespace_prefix my_ns | |
| cci task run generate_dataset_mapping --org qa -o namespace_prefix my_ns |
Removing python install from .readthedocs.yml Fixing doc broken references Fixing broken references in documentation and removing unicode emojis from doc gen Applying recommended PR changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.