Add new tasks get_assignable_permission_sets and get_assignable_licenses#3892
Merged
Add new tasks get_assignable_permission_sets and get_assignable_licenses#3892
Conversation
jstvz
reviewed
Apr 15, 2025
Contributor
jstvz
left a comment
jstvz
left a comment
There was a problem hiding this comment.
I'm a bit ambivalent about this PR. On one hand, It's actually a bug to return licenses that aren't available for assignment to a user. On the other hand, CumulusCI users may be relying on the current behavior because they have a use case for checking for the existence of a license.
Given that the task description is ambiguous ("Retrieves a list of the currently available license definition keys"), what about adding leaving the current behavior as-is and instead adding two new tasks (get_assignable_licenses and get_assignable_permission_sets) and clarifying the difference between them via the task description?
…_assignable_licenses
vsbharath
force-pushed
the
get_available_permsets
branch
from
09e1c8d to
8c7bb41
Compare
vsbharath
changed the title
jstvz
approved these changes
Apr 15, 2025
Contributor
jstvz
left a comment
jstvz
left a comment
There was a problem hiding this comment.
LTGM, thanks. Don't forget the release note.
jstvz
changed the title
jstvz
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new tasks to retrieve assignable licenses and permission sets: