fix: include --output-dir only when output_dir is provided#3920
Merged
Conversation
PR #3901 added the `--output-dir` option to the `retrieve_components` task. When `output_dir` was `None`, it used the target (e.g. `force-app`) as the value. The Salesforce CLI rejects using a package directory as the output directory, so this caused an error reported in #3918. This commit builds the sfdx args without `--output-dir` by default. It appends `--output-dir <path>` only when `output_dir` is not `None`. This lets the CLI select the default output dir when output_dir is not given. When output_dir is not set, files go to the package directory from the manifest, as the CLI expects.
vsbharath
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3901 added the
--output-diroption to theretrieve_componentstask. When
output_dirwasNone, it used the target (e.g.force-app) asthe value. The Salesforce CLI rejects using a package directory as
the output directory, so this caused an error reported in #3918.
This commit builds the sfdx args without
--output-dirby default.It appends
--output-dir <path>only whenoutput_diris notNone. This lets the CLI select the default output dir when output_diris not given.
When output_dir is not set, files go to the package directory from the
manifest, as the CLI expects.