Skip to content

@W-19854606: Strict Mode & Raise validation errors for missing schema and permissions#3937

Merged
aditya-balachander merged 3 commits intomainfrom
W-19854606/validation-bug-fixes
Dec 19, 2025
Merged

@W-19854606: Strict Mode & Raise validation errors for missing schema and permissions#3937
aditya-balachander merged 3 commits intomainfrom
W-19854606/validation-bug-fixes

Conversation

@aditya-balachander
Copy link
Copy Markdown
Contributor

@aditya-balachander aditya-balachander commented Dec 12, 2025

Snowfakery strict-mode

  • Added strict-mode support to the snowfakery task in CumulusCI.
  • When enabled, the Snowfakery recipe is first validated using Snowfakery’s strict-mode.
  • Standard mapping validations then run as usual.
  • Data loading occurs only if both validations succeed.
  • If either validation fails, errors are raised and the data load does not proceed.

Bug Fixes

What changed and why

  • Missing sObject: now an error (previously warning in validate-only). The run would fail at execution time, so validation should surface it as blocking.
  • sObject permission denied: now an error. Lack of createable/updateable/queryable already fails execution; validation now mirrors that.
  • Missing field or field not visible: now an error when not using drop_missing. Execution would fail without the field, so validation should flag it.
  • Field permission denied: now an error when not using drop_missing. Lack of required FLS blocks execution; validation should indicate that.
  • Ambiguous namespaced field (both f and inject(f) exist): kept as warning. The loader explicitly chooses one and can proceed; this is informational, not blocking.

Why change warnings to errors?

  • Validation-only previously gave “green” results despite conditions that would raise BulkDataException at runtime. Converting these to errors makes validation truthful and prevents false confidence.
  • Users can still opt into drop_missing to auto-trim problematic fields/steps; otherwise, the validation report now matches runtime strictness.

@aditya-balachander aditya-balachander requested review from a team and jkasturi-sf December 12, 2025 07:24
@aditya-balachander aditya-balachander changed the title @W-19854606: Raise validation errors for missing schema and permissions @W-19854606: Strict Mode & Raise validation errors for missing schema and permissions Dec 19, 2025
@aditya-balachander aditya-balachander enabled auto-merge (squash) December 19, 2025 09:30
Copy link
Copy Markdown
Contributor

@jkasturi-sf jkasturi-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aditya-balachander aditya-balachander merged commit 5177267 into main Dec 19, 2025
23 of 24 checks passed
@aditya-balachander aditya-balachander deleted the W-19854606/validation-bug-fixes branch December 19, 2025 09:32
dipakparmar pushed a commit to ClaritiSoftware/CumulusCI that referenced this pull request Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants