Skip to content

Issue-3938 rest_deploy should throw errors just like SOAP deploy does #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yippie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Issue-3938 rest_deploy should throw errors just like SOAP deploy does #3940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cumulusci/salesforce_api/rest_deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ def __call__(self):
self.task.logger.error(
f"Deployment request failed with status code {response.status_code}"
)
raise MetadataApiError(f"Deployment request failed with status code {response.status_code}", response)

# Set the purge_on_delete attribute based on org type
def _set_purge_on_delete(self, purge_on_delete):
Expand Down Expand Up @@ -112,10 +113,14 @@ def _monitor_deploy_status(self, deploy_request_id):
if response_json["deployResult"]["status"] not in ["InProgress", "Pending"]:
# Handle the case when status has Failed
if response_json["deployResult"]["status"] == "Failed":
error_log = ''
for failure in response_json["deployResult"]["details"][
"componentFailures"
]:
self.task.logger.error(self._construct_error_message(failure))
error_message = self._construct_error_message(failure)
self.task.logger.error(error_message)
error_log += error_message + "\n"
raise MetadataComponentFailure(error_log, response)
return
time.sleep(5)

Expand Down
Loading