Expose Rollback Option in the Snowfakery Task#3958
Merged
aditya-balachander merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
jstvz
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The
LoadDatatask already supports anenable_rollbackoption that, when set toTrue, performs a cleanup of all successfully-inserted records if a row-level error is encountered during a load. This is essential for keeping orgs in a consistent state when a data load partially fails.The
snowfakerytask drivesLoadDatainternally (viaGenerateAndLoadDataFromYamlsubtasks), but previously had no way to passenable_rollbackthrough to those subtasks — meaning users had no way to get rollback behaviour when using the Snowfakery task.Changes
cumulusci/tasks/bulkdata/snowfakery.pyenable_rollbacktotask_optionswith documentation._validate_options.TaskOptionsErrorifenable_rollback=Trueis combined with anyrun_until_*option — those run across many independent batches, each of which commits separately, so only the failing batch would be rolled back, which would be confusing behaviour.LoadDatasubtasks via bothadditional_load_options(for parallel batch loaders) and_run_generate_and_load_subtask(for the initial/validation batch).cumulusci/tasks/bulkdata/load.py_init_optionswhenenable_rollback=Trueandignore_row_errors=Trueare both set, since row errors are suppressed before the rollback trigger is reached in that combination.