feat(core): add bulkStream + bulkStreamWithResult for direct BulkItem ingest...#98
Merged
Merged
Conversation
… ingest
Stage 1 of the CTAS / INSERT INTO … SELECT-with-JOIN design
Adds two public methods to BulkApi:
bulkStream(items: Source[BulkItem, NotUsed])
: Source[Either[FailedDocument, SuccessfulDocument], NotUsed]
bulkStreamWithResult(items, callbacks): Future[BulkResult]
…earch paths `ElasticClientDelegator.toBulkElasticAction`, `extractBulkResults`, `actionToBulkItem`, `bulkFlow`, and `MetricsElasticClient.singleSearchAsync` / `multiSearchAsync` cast the result of `delegate.*` through bare `.asInstanceOf` (no type argument). Scala infers `Nothing`, and the synthetic cast at the call site explodes the moment the delegated pipeline is exercised end-to-end (`BulkOperation → scala.runtime.Nothing$` ClassCastException). Latent — there was no real caller of `bulkStream`/`bulkStreamWithResult` through the metrics/monitored delegator chain until the sidecar row-1 INSERT/CTAS executor in softclient4es-arrow added one. Alias `delegate` to a stable local `val d` (the field is `def`, not `val`, so it isn't a stable identifier on its own) and project to the right path-dependent type — `d.BulkActionType`, `d.BulkResultType`, or this trait's own `Future[ElasticResult[ElasticResponse]]`. All abstract A/R types still erase to Object, so the runtime cast is a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...
fix(core): project bare
.asInstanceOfin delegator + metrics bulk/search paths